Skip to content

[v4.6] libpod: use new libcontainer BlockIO constructors #19111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 4, 2023
Merged

[v4.6] libpod: use new libcontainer BlockIO constructors #19111

openshift-merge-robot merged 1 commit into from
Jul 4, 2023

Conversation

@openshift-cherrypick-robot
Copy link
Collaborator

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jul 4, 2023

This is an automated cherry-pick of #19101

/assign vrothberg

none

@haircommander
libpod: use new libcontainer BlockIO constructors
7680e50 
[NO NEW TESTS NEEDED]

Signed-off-by: Peter Hunt <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 4, 2023
Merged
vrothberg
vrothberg approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Luap99 PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2023
Luap99
Luap99 reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit be5e2dc into containers:v4.6 Jul 4, 2023
@haircommander
Copy link
Collaborator

haircommander commented Jul 5, 2023

/cherry-pick v4.5

@openshift-cherrypick-robot
Copy link
Collaborator Author

openshift-cherrypick-robot commented Jul 5, 2023

@haircommander: only containers org members may request cherry picks. You can still do the cherry-pick manually.

Details

In response to this:

/cherry-pick v4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Collaborator

haircommander commented Jul 5, 2023

done manually #19136

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Luap99 Luap99 Luap99 left review comments

+1 more reviewer

@vrothberg vrothberg vrothberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrothberg vrothberg

@Luap99 Luap99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @haircommander @vrothberg @Luap99 @openshift-merge-robot