libpod: use new libcontainer BlockIO constructors

[haircommander]

libpod as it currently is is not compatible with newer tagged version of runc, as on that release branch the BlockIO fields are private. However, newer libpod need to use a newer version of runc (which happens to have the blockIO bits exported) to reduce the binary size of podman.

a compromise is libpod can use the constructors where applicable, so podman can build its own smaller binary (with a newer runc) as well as be compatible with the runc 1.1.z branch

Does this PR introduce a user-facing change?

none

EDIT (@lsm5)
[NO NEW TESTS NEEDED]

[lsm5]

hmm, weird that Build Each Commit failed but packit rpm builds did not.

Change LGTM though.

[lsm5]

@Luap99 @mheon @vrothberg PTAL

[lsm5]

/lgtm
/hold

[mheon]

LGTM on my end

[lsm5]

/lgtm
/hold

[Luap99]

Bumping runc is fine but it should go forward not backwards. We cannot use the v1.1 branch, we want the latest code from main because otherwise runc will bloat us for over 2MB.
The reason the replace is there because go is unable to get the fact that our commit is actually newer then the latest release from the runc v1.1 branch. Please see containers/common#936 for the reasons.

[haircommander]

@Luap99 @mheon @lsm5 how about this? I have updated the description with motivation, and tested the vendor dance in cri-o to verify it works as I wish it to.

[lsm5]

LGTM

[mheon]

No objections here

[mheon]

But I'll hold until @Luap99 can give a final OK

[vrothberg]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, lsm5, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lsm5,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

/lgtm

[Luap99]

I still think we should at least bump runc to the current main but as for this PR I think this is the best solution given you want to backport this.

[Luap99]

/hold cancel

[vrothberg]

/cherry-pick v4.6

[openshift-cherrypick-robot]

@vrothberg: new pull request created: #19111

Details

In response to this:

/cherry-pick v4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.