Skip to content

Conversation

@haircommander
Copy link
Collaborator

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

none

@haircommander
Copy link
Collaborator Author

PTAL @vrothberg @mheon @Luap99 @lsm5

@mheon
Copy link
Member

mheon commented Jul 5, 2023

LGTM

@lsm5
Copy link
Member

lsm5 commented Jul 5, 2023

@haircommander remind me why the cherrypick to this branch. Is it for rhel ?

@lsm5
Copy link
Member

lsm5 commented Jul 5, 2023

we can ignore packit failures for now, and maybe only do centos builds for rhel branches

@lsm5 lsm5 closed this Jul 5, 2023
@lsm5 lsm5 reopened this Jul 5, 2023
@lsm5
Copy link
Member

lsm5 commented Jul 5, 2023

hit the wrong button, my bad.

@haircommander
Copy link
Collaborator Author

CRI-O will eventually vendor this commit, no need for a packaged version or even a tag.

[NO NEW TESTS NEEDED]

Signed-off-by: Peter Hunt <[email protected]>
@lsm5
Copy link
Member

lsm5 commented Jul 5, 2023

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@Luap99
Copy link
Member

Luap99 commented Jul 6, 2023

/approve
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 813f1b5 into containers:v4.5 Jul 6, 2023
@openshift-cherrypick-robot
Copy link
Collaborator

@saschagrunert: new pull request could not be created: failed to create pull request against containers/podman#v4.6 from head openshift-cherrypick-robot:cherry-pick-19136-to-v4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between containers:v4.6 and openshift-cherrypick-robot:cherry-pick-19136-to-v4.6"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

Details

In response to this:

/cherry-pick v4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrothberg
Copy link
Member

We would need this for 4.6 / main as well, right?

They're already in both branches. We should only backport after things are in main.

@saschagrunert
Copy link
Member

Found the issue: v4.6.0-rc1 does not have the change in yet, so we wait for another RC or the final version. :)

@lsm5
Copy link
Member

lsm5 commented Jul 13, 2023

rc2 should be going out today

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants