-
Notifications
You must be signed in to change notification settings - Fork 3k
[v4.5] libpod: use new libcontainer BlockIO constructors #19136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4.5] libpod: use new libcontainer BlockIO constructors #19136
Conversation
|
PTAL @vrothberg @mheon @Luap99 @lsm5 |
|
LGTM |
|
@haircommander remind me why the cherrypick to this branch. Is it for rhel ? |
|
we can ignore packit failures for now, and maybe only do centos builds for rhel branches |
|
hit the wrong button, my bad. |
|
CRI-O will eventually vendor this commit, no need for a packaged version or even a tag. |
[NO NEW TESTS NEEDED] Signed-off-by: Peter Hunt <[email protected]>
e1ef65d to
9f90a86
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@saschagrunert: new pull request could not be created: failed to create pull request against containers/podman#v4.6 from head openshift-cherrypick-robot:cherry-pick-19136-to-v4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between containers:v4.6 and openshift-cherrypick-robot:cherry-pick-19136-to-v4.6"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
They're already in both branches. We should only backport after things are in main. |
|
Found the issue: v4.6.0-rc1 does not have the change in yet, so we wait for another RC or the final version. :) |
|
rc2 should be going out today |
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?