Skip to content

Conversation

@mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Nov 1, 2019

See #744 (comment) below.

@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 21, 2019

Finally passed with

SKOPEO_REPO = mtrmac/skopeo
SKOPEO_BRANCH = test-failures

which I’ll now drop. This PR will show test failures until containers/skopeo#760 is merged; afterwards, it should be re-tested, and tests will hopefully succeed, unblocking c/image CI.

@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 21, 2019

Update the Ubuntu host to get newer kernel because crun (used in newer fedora containers) calls statx(), which is available since kernel 4.11, but Ubuntu Trusty only has 4.4. The glibc emulation of statx() fails with EINVAL on unrecognized flags, which crun does not recognize, so it does not fall back to older syscalls.

containers/crun#189

Based on previous testing, this should unblock c/image CI after containers/skopeo#760 is merged.

@vrothberg PTAL.

@mtrmac mtrmac changed the title DO NOT MERGE: Experimenting with test failures Update the Ubuntu host to get newer kernel Nov 21, 2019
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @mtrmac! Thanks! Feel free to merge after the rebase.

... because crun (used in newer fedora containers) calls statx(), which is
available since kernel 4.11, but Ubuntu Trusty only has 4.4. The glibc
emulation of statx() fails with EINVAL on unrecognized flags, which crun
does not recognize, so it does not fall back to older syscalls.

containers/crun#189

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac merged commit accb22a into containers:master Nov 22, 2019
@mtrmac mtrmac deleted the test-failures branch November 22, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants