Fix destination stream overwrite on progress #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM although tests seem a little wonky. |
saschagrunert
force-pushed
the
interface-fix
branch
from
551ba68 to
c3bff30
Compare
Member
Author
|
Hm, |
Member
|
We can merge once tests pass. |
Collaborator
|
@saschagrunert Please rebase on top of #744 , the CI should pass then. |
The new-initialization of the `io.Reader` `destStream` caused to break the progress reader calling `Read` at all, which is now fixed. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
saschagrunert
force-pushed
the
interface-fix
branch
from
c3bff30 to
d3b9bbb
Compare
Member
Author
|
Alright, rebased on top of the latest master branch. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new-initialization of the
io.ReaderdestStreamcaused to breakthe progress reader calling
Readat all, which is now fixed.