Support running tests from c/image #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
reviewed
Nov 21, 2019
Member
vrothberg
left a comment
vrothberg
left a comment
There was a problem hiding this comment.
Are we ready to go? Before merging, the "x" commit could need a commit message.
Contributor
Author
|
For this PR to work, both the tests in here and containers/image#744 need to succeed, which is not currently the case. |
This allows using the vendored dependencies instead of
searching for them in $GOPATH and elsewhere.
This does not necessarily matter for skopeo itself, but
the test-skopeo Makefile target in containers/image uses
(go mod edit -replace) to replace the vendored c/image with
a locally-edited copy; skopeo's (make check) then runs tests in
a container which does not have access to this locally-edited
copy, and since Go 1.13 this causes (go {list,test,vet})
to fail if -mod=vendor is not used.
Signed-off-by: Miloslav Trmač <[email protected]>
(go list) removes the vendor subdirectory automatically since Go 1.9. Signed-off-by: Miloslav Trmač <[email protected]>
The nested podman tries to write to it. This primarily only removes noise from logs, it does not seem to significantly change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Experimentally, this seems to help with localhost access inside that container (but I have no idea what's the reason for that). Signed-off-by: Miloslav Trmač <[email protected]>
Apparently we run into the 10-minute timeout now in Travis. Signed-off-by: Miloslav Trmač <[email protected]>
… testing This image is about 100 MB instead of about 2 GB for the Server Core, decreasing disk requirements and hopefully significantly speeeding up integration tests. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
test-failures
branch
from
82e9754 to
af07348
Compare
mtrmac
changed the title
Contributor
Author
|
Yay, success! This primarily modifies the test suite so that it can again succeed when run from c/image’s The two major elements are:
containers/image#744 , with
(which will be momentarily removed) succeeds. @vrothberg PTAL. |
Member
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #760 (comment) below.