Update deps for August 2025 #2851
Conversation
smaye81
force-pushed
the
sayers/deps_aug_25
branch
2 times, most recently
from
897772e to
f1459fc
Compare
| |------|-----:|----------| | ||
| | esbuild (js) | 123,964 bytes | dist/js/index.js | | ||
| | esbuild (ts) | 123,964 bytes | dist/ts/index.js | | ||
| | esbuild (js) | 135,295 bytes | dist/js/index.js | |
There was a problem hiding this comment.
Hmm, i wonder what caused an additional 10k+ increase to bundle size 🤔
There was a problem hiding this comment.
Yeah, and even weirder Parcel didn't change. I'm wondering if it's something in our configuration for these bundlers? @timostamm any ideas what may be the culprit here?
There was a problem hiding this comment.
Protobuf-ES 2.6.1 includes an update to google-protobuf v31.1 with a small bump in bundle size (see PR), but that should be much smaller than 10kb.
Would be good to know what's going on here. Can you diff the bundled output against the previous one?
There was a problem hiding this comment.
Just updated the connect bundle size benchmark, bump was small, as expected: connectrpc/connect-es#1533
There was a problem hiding this comment.
After some investigation, the bump in size is predominantly related to two PRs:
- Fix closed enum parsing bufbuild/protobuf-es#1170 which imports
BinaryWriterfrombinary-encoding.js - Update to google protobuf v31.1 bufbuild/protobuf-es#1168 which updates google protobuf, causing a slight bump in a generated descriptor file.
We have mitigated the effect of 1170 with PR bufbuild/protobuf-es#1197, which, once released, will be pulled in with next month's dependabot updates.
paul-sachs
left a comment
paul-sachs
left a comment
There was a problem hiding this comment.
No blockers, just curious about the root cause of the bundle size increase
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
smaye81
force-pushed
the
sayers/deps_aug_25
branch
from
3ec7f45 to
4b5e113
Compare
Signed-off-by: Timo Stamm <ts@timostamm.de>
SSIA --------- Signed-off-by: Steve Ayers <sayers@buf.build> Signed-off-by: Timo Stamm <ts@timostamm.de> Co-authored-by: Timo Stamm <ts@timostamm.de> Signed-off-by: Steve Ayers <sayers@buf.build>
3 participants
SSIA