Conversation
srikrsna
approved these changes
Jul 17, 2025
srikrsna-buf
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protobuf enums are open in proto3, and closed in proto2. An open enum field can contain values not defined in the enum (for example from a future schema change). A closed enum field can only contain values defined in the enum.
The way we handle closed enums when parsing with
fromBinaryis flawed. While we never set an enum field to a value not defined in the enum, we do raise a parse error. The correct behavior is to put the unknown value into the set of unknown fields instead. This PR fixes the behavior.