Fix parcel bundle size report #2852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
commented
Aug 4, 2025
Comment on lines
+7
to
+8
| "build:js": "parcel build --log-level error --no-cache --no-content-hash --target=js", | ||
| "build:ts": "parcel build --log-level error --no-cache --no-content-hash --target=ts", |
Member
Author
There was a problem hiding this comment.
We have to run parcel twice, so that it produces two separate and independent outputs. Otherwise, it still generates imports, and we didn't account for those imports when summing up the size.
smaye81
approved these changes
Aug 4, 2025
Yaheo
approved these changes
Aug 5, 2025
| "scripts": { | ||
| "pregenerate": "rm -rf dist", | ||
| "generate": "buf generate ../proto --template ../buf.gen.yaml", | ||
| "build": "parcel build --log-level error --no-cache --no-content-hash", |
| |------|-----:|----------| | ||
| | esbuild (js) | 135,295 bytes | dist/js/index.js | | ||
| | esbuild (ts) | 135,295 bytes | dist/ts/index.js | | ||
| | parcel (js) | 1,841 bytes | dist/js/js.cf4251ac.js | |
There was a problem hiding this comment.
| parcel (ts) | 1,845 bytes | dist/ts/ts.dc635180.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.