CONFLUENT: Remove support-metrics-common#258
Merged
Merged
Conversation
C3 no longer depends on it: confluentinc/blueway#2015 There's a WIP PR for ksqldb: https://github.com/confluentinc/ksql/pull/4474/files
Member
|
I see bunch of files gone. So I assume C3 now has its own version of it and no one needs this code anymore. |
Member
Author
|
Vikas Singh (@soondenana) that's what the PR description says. :) (C3 doesn't need it anymore and is deleting the code. ksqldb is taking the code they need). |
Vikas Singh (soondenana)
approved these changes
Feb 7, 2020
Vikas Singh (soondenana)
left a comment
Vikas Singh (soondenana)
left a comment
Member
There was a problem hiding this comment.
Thanks Ismael Juma (@ijuma). LGTM
Removed by mistake
Ismael Juma (ijuma)
changed the title
…etrics-common * confluent/master: (76 commits) KAFKA-9530; Fix flaky test `testDescribeGroupWithShortInitializationTimeout` (apache#8154) HOTFIX: fix NPE in Kafka Streams IQ (apache#8158) MINOR: set scala version automatically based on gradle.properties KAFKA-9577; SaslClientAuthenticator incorrectly negotiates SASL_HANDSHAKE version (apache#8142) KAFKA-9441: Add internal TransactionManager (apache#8105) MINOR: Document endpoints for connector topic tracking (KIP-558) MINOR: Standby task commit needed when offsets updated (apache#8146) Changes to migrate to Artifactory (#263) KAFKA-9206; Throw KafkaException on CORRUPT_MESSAGE error in Fetch response (apache#8111) MINOR: Remove unwanted regexReplace on tests/kafkatest/__init__.py KAFKA-9586: Fix errored json filename in ops documentation KAFKA-9575: Mention ZooKeeper 3.5.7 upgrade KAFKA-9481: Graceful handling TaskMigrated and TaskCorrupted (apache#8058) HOTFIX: don't try to remove uninitialized changelogs from assignment & don't prematurely mark task closed (apache#8140) MINOR: Fix javadoc at org.apache.kafka.clients.producer.KafkaProducer.InterceptorCallback#onCompletion (apache#7337) MINOR: Improve EOS example exception handling (apache#8052) MINOR: Fix a number of warnings in clients test (apache#8073) MINOR: Update shell scripts to support z/OS system (apache#7913) MINOR: Wording fix in Streams DSL docs (apache#5692) MINOR: Add missing @test annotation to MetadataTest#testMetadataMerge (apache#8141) ...
Vikas Singh (soondenana)
approved these changes
Feb 24, 2020
Vikas Singh (soondenana)
left a comment
Vikas Singh (soondenana)
left a comment
Member
There was a problem hiding this comment.
LGTM.
I have only one comment, please take a look if that makes sense.
| apacheda: "1.0.2", | ||
| apacheds: "2.0.0-M24", | ||
| argparse4j: "0.7.0", | ||
| avro: "1.9.1", |
There was a problem hiding this comment.
Does this need to be taken out of confluent-import-control.xml too?
Member
Author
There was a problem hiding this comment.
Good point, we can. remove that file. Done.
Andrew Egelhofer (andrewegel)
pushed a commit
that referenced
this pull request
Nov 16, 2021
Reviewers: Colin Hicks <colin.hicks@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C3 no longer needs it (functionality removed):
https://github.com/confluentinc/blueway/pull/2015
ksqlDB imported the relevant code into their tree:
confluentinc/ksql#4474
Committer Checklist (excluded from commit message)