Skip to content

Changes to migrate to Artifactory#263

Merged
Mohinish (mohnishbasha) merged 2 commits into
masterfrom
move2Jfrog
Feb 21, 2020
Merged

Changes to migrate to Artifactory#263
Mohinish (mohnishbasha) merged 2 commits into
masterfrom
move2Jfrog

Conversation

@mohnishbasha

@mohnishbasha Mohinish (mohnishbasha) commented Feb 13, 2020

Copy link
Copy Markdown

Move kafka build to Artifactory

Use Gradle Artifactory Credentials.

Kafka Team, please help cherry pick this into other branches once PR build passes and merged into master

@cmccabe

Colin Patrick McCabe (cmccabe) commented Feb 13, 2020

Copy link
Copy Markdown

This doesn't look like a complete fix. We need to remove the other references to nexus in the build files, right?

[cmccabe@zeratul ce-kafka]$ git grep nexus
Jenkinsfile:            stage("Publish to nexus") {
Jenkinsfile:                def mavenUrl = 'https://nexus.confluent.io/repository/maven-snapshots/'
build.gradle:      name 'confluent-nexus'
build.gradle:      url 'https://nexus.confluent.io/repository/maven-public'
mk-include/cc-node.mk:NPM_REGISTRY ?= https://nexus.confluent.io/repository/npm-internal/
mk-include/cc-node.mk:  @echo "https://nexus.confluent.io not logged in, Username, Password, and Email not found in environment, prompting for login:" && \
mk-include/cc-node.mk:          npm login --registry=https://nexus.confluent.io/repository/npm-internal/ --scope=@confluent

soondenana
Vikas Singh (soondenana) reviewed Feb 13, 2020
View reviewed changes
Comment thread Jenkinsfile

if (config.publish && config.isDevJob) {
configFileProvider([configFile(fileId: 'Gradle Nexus Settings', variable: 'GRADLE_NEXUS_SETTINGS')]) {
configFileProvider([configFile(fileId: 'Gradle-Artifactory-Settings', variable: 'GRADLE_NEXUS_SETTINGS')]) {

@soondenana Vikas Singh (soondenana) Feb 13, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to rename GRADLE_NEXUS_SETTINGS?

@mohnishbasha Mohinish (mohnishbasha) Feb 21, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can leave it as is for now, i believe the variable is being used in downstream scripts and configs.

@mohnishbasha

Mohinish (mohnishbasha) commented Feb 13, 2020

Copy link
Copy Markdown
Author

This doesn't look like a complete fix. We need to remove the other references to nexus in the build files, right?

[cmccabe@zeratul ce-kafka]$ git grep nexus
Jenkinsfile:            stage("Publish to nexus") {
Jenkinsfile:                def mavenUrl = 'https://nexus.confluent.io/repository/maven-snapshots/'
build.gradle:      name 'confluent-nexus'
build.gradle:      url 'https://nexus.confluent.io/repository/maven-public'
mk-include/cc-node.mk:NPM_REGISTRY ?= https://nexus.confluent.io/repository/npm-internal/
mk-include/cc-node.mk:  @echo "https://nexus.confluent.io not logged in, Username, Password, and Email not found in environment, prompting for login:" && \
mk-include/cc-node.mk:          npm login --registry=https://nexus.confluent.io/repository/npm-internal/ --scope=@confluent

These are only true for ce-kafka and not for kafka.
ce-kafka changes are available at this pr:
https://github.com/confluentinc/ce-kafka/pull/1211

@rondagostino

Ron Dagostino (rondagostino) commented Feb 13, 2020

Copy link
Copy Markdown

https://github.com/confluentinc/ce-kafka/pull/1211 is superseded by https://github.com/confluentinc/ce-kafka/pull/1213.

soondenana
Vikas Singh (soondenana) approved these changes Feb 21, 2020
View reviewed changes

@soondenana Vikas Singh (soondenana) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mohnishbasha
Mohinish (mohnishbasha) merged commit 59933f7 into master Feb 21, 2020
@mohnishbasha
Mohinish (mohnishbasha) deleted the move2Jfrog branch February 21, 2020 19:47
Ron Dagostino (rondagostino) pushed a commit that referenced this pull request Feb 21, 2020
@mohnishbasha @rondagostino
Changes to migrate to Artifactory (#263)
f53bd19 
* Changes to migrate to Artifactory
Vikas Singh (soondenana) pushed a commit that referenced this pull request Feb 21, 2020
@mohnishbasha @soondenana
CONFLUENT: Changes to migrate to Artifactory (#263)
6b71218 
* Changes to migrate to Artifactory

(cherry picked from commit 59933f7)
Vikas Singh (soondenana) pushed a commit that referenced this pull request Feb 21, 2020
@mohnishbasha @soondenana
CONFLUENT: Changes to migrate to Artifactory (#263)
98ad56f 
* Changes to migrate to Artifactory

(cherry picked from commit 59933f7)
(cherry picked from commit 6b71218)
Vikas Singh (soondenana) pushed a commit that referenced this pull request Feb 21, 2020
@mohnishbasha @soondenana
CONFLUENT: Changes to migrate to Artifactory (#263)
318beff 
* Changes to migrate to Artifactory

(cherry picked from commit 59933f7)
(cherry picked from commit 6b71218)
(cherry picked from commit 98ad56f)
@rondagostino Ron Dagostino (rondagostino) mentioned this pull request Feb 24, 2020
Closed
3 tasks
Ismael Juma (ijuma) added a commit that referenced this pull request Feb 24, 2020
@ijuma
Merge remote-tracking branch 'confluent/master' into remove-support-m…
9f774d7 
…etrics-common

* confluent/master: (76 commits)
  KAFKA-9530; Fix flaky test `testDescribeGroupWithShortInitializationTimeout` (apache#8154)
  HOTFIX: fix NPE in Kafka Streams IQ (apache#8158)
  MINOR: set scala version automatically based on gradle.properties
  KAFKA-9577; SaslClientAuthenticator incorrectly negotiates SASL_HANDSHAKE version (apache#8142)
  KAFKA-9441: Add internal TransactionManager (apache#8105)
  MINOR: Document endpoints for connector topic tracking (KIP-558)
  MINOR: Standby task commit needed when offsets updated (apache#8146)
  Changes to migrate to Artifactory (#263)
  KAFKA-9206; Throw KafkaException on CORRUPT_MESSAGE error in Fetch response (apache#8111)
  MINOR: Remove unwanted regexReplace on tests/kafkatest/__init__.py
  KAFKA-9586: Fix errored json filename in ops documentation
  KAFKA-9575: Mention ZooKeeper 3.5.7 upgrade
  KAFKA-9481: Graceful handling TaskMigrated and TaskCorrupted (apache#8058)
  HOTFIX: don't try to remove uninitialized changelogs from assignment & don't prematurely mark task closed (apache#8140)
  MINOR: Fix javadoc at org.apache.kafka.clients.producer.KafkaProducer.InterceptorCallback#onCompletion (apache#7337)
  MINOR: Improve EOS example exception handling (apache#8052)
  MINOR: Fix a number of warnings in clients test (apache#8073)
  MINOR: Update shell scripts to support z/OS system (apache#7913)
  MINOR: Wording fix in Streams DSL docs (apache#5692)
  MINOR: Add missing @test annotation to MetadataTest#testMetadataMerge (apache#8141)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soondenana Vikas Singh (soondenana) soondenana approved these changes
@cmccabe Colin Patrick McCabe (cmccabe) Awaiting requested review from cmccabe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohnishbasha @cmccabe @rondagostino @soondenana