chore: include support metrics in the project#4474
Conversation
|
I will be helping bring this home. Some follow-ups:
|
|
Thank you Colin Hicks (@colinhicks)! A couple of tests that can also be removed:
|
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ |
There was a problem hiding this comment.
License should be updated to match ksqldb's template.
|
Apurva Mehta (@apurvam), I should rebase this onto |
2b7b5f8 to
e57d650
Compare
|
Verified metrics send as expected. See description for testing notes. |
Almog Gavra (agavra)
left a comment
There was a problem hiding this comment.
Given this is a copy of existing code I didn't give it a thorough review, just a quick scan to see that it does what it claims to 😝
|
Colin Hicks (@colinhicks) When merging this, please set yourself as the author since you did all the work. :) |
ksqlDB is the only user of these classes, so include it in the project instead of consuming it as a library.
144d4e3 to
476253a
Compare
|
Ismael Juma (@ijuma), I could not convince GitHub to make the squash-merge commit in my name, even after rewriting the author name in the initial commit. If it's best to alter a80a7d8 with my name, we'll need to ask Almog Gavra (@agavra) or another maintainer to amend it – I don't have code-owner rights to this repo. |
|
Not sure if GH's behavior has changed here. Noting for myself in the future: squash merging PRs with a different author than the PR creator seems to require manually merging with |
|
I see. One way to make this sort of work is to use co-authored-by to assign multiple authors. |
C3 no longer needs it (functionality removed): confluentinc/blueway#2015 ksqlDB imported the relevant code into their tree: confluentinc/ksql#4474 Reviewers: Vikas Singh <vikas@confluent.io>
Description
ksqlDB is the only user of these classes, so include it in the project instead of consuming it as a library.
Source files were copied from Confluent Kafka's support-metrics-common module. They were updated to match ksqlDB checkstyle and to remove functionality that submits metrics to a Kafka topic (this was never used by ksqlDB).
Testing done
Tested by building a docker image and running it locally using the docker-compose file in the ksqldb.io quickstart as a template. Based on inspecting network traffic sent at server startup, there was an HTTP POST to the version-checker endpoint with the expected Avro payload.
(The ksqldb-server container was configured to send data to the insecure version-checker endpoint, so that the payload could be more easily verified)
Reviewer checklist