[admin] Add consumer group bindings for KIP 222, 518, 396 (partial) and DeleteConsumerGroups #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emasab
force-pushed
the
feature/list-and-alter-offsets
branch
3 times, most recently
from
74675fa
to
2c4d900
Compare
emasab
changed the title
emasab
changed the title
|
Added a commit fixing the tests (the tests were not changed while changing the return type of DescribeConsumerGroups) |
DescribeConsumerGroups, ListConsumerGroupOffsets (KIP-222) DeleteConsumerGroups, AlterConsumerGroupOffsets (KIP-396), Allow listing consumer groups per state (KIP-518), Co-authored-by: Emanuele Sabellico <[email protected]> Co-authored-by: Santwana Verma <[email protected]>
also contains some documentation, changelog changes (minor).
emasab
force-pushed
the
feature/list-and-alter-offsets
branch
from
16f671d
to
ef0fffa
Compare
emasab
commented
Jan 16, 2023
There was a problem hiding this comment.
Great job @milindl @vsantwana! I've moved this to an internal branch and opened the PR, so @milindl go on with approving and merging it.
milindl
approved these changes
Jan 17, 2023
1 task
PrasanthV454
pushed a commit
that referenced
this pull request
Mar 17, 2023
…nd DeleteConsumerGroups (#923) Implement ListConsumerGroups, DescribeConsumerGroups, ListConsumerGroupOffsets (KIP-222), DeleteConsumerGroups, AlterConsumerGroupOffsets (KIP-396), Allow listing consumer groups per state (KIP-518). Co-authored-by: Milind L <[email protected]> Co-authored-by: Santwana Verma <[email protected]>
This was referenced May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes #852 (by @vsantwana) - the DeleteGroups implementation.
The rest of the bindings are - ListConsumerGroups, DescribeConsumerGroups, AlterConsumerGroupOffsets, and ListConsumerGroupOffsets.