[admin] Add consumer group bindings for KIP-88, 222, 518, 396 (partial) #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milindl
force-pushed
the
feature/list-and-alter-offsets
branch
from
af98bbe
to
742930f
Compare
milindl
changed the title
milindl
force-pushed
the
feature/list-and-alter-offsets
branch
from
742930f
to
59e4ba7
Compare
milindl
changed the title
Also modifies the test for DeleteGroups to use the new bindings
State in ListConsumerGroups
milindl
force-pushed
the
feature/list-and-alter-offsets
branch
from
299c2df
to
cd3057d
Compare
milindl
force-pushed
the
feature/list-and-alter-offsets
branch
2 times, most recently
from
16bc999
to
48839ff
Compare
milindl
force-pushed
the
feature/list-and-alter-offsets
branch
from
48839ff
to
52e8fc4
Compare
milindl
force-pushed
the
feature/list-and-alter-offsets
branch
from
ee98ebe
to
2c96638
Compare
supports methods.
emasab
requested changes
Dec 13, 2022
examples/admin_alter_consumer_group_offsets/admin_alter_consumer_group_offsets.go
Outdated
Show resolved
Hide resolved
examples/admin_list_consumer_group_offsets/admin_list_consumer_group_offsets.go
Outdated
Show resolved
Hide resolved
milindl
force-pushed
the
feature/list-and-alter-offsets
branch
from
b3dcdad
to
5b58e8c
Compare
|
Addressed most changes, except a few doubts left as comment replies. |
Also changes the tests so we don't end up deleting the topic specified in testconf.json.
emasab
reviewed
Jan 10, 2023
kafka/kafka.go
Outdated
| } | ||
|
|
||
| // GroupTopicPartitions represents a consumer group's TopicPartitions. | ||
| type GroupTopicPartitions struct { |
There was a problem hiding this comment.
We could name it ConsumerGroupTopicPartitions to keep naming consistent with method name, as Pranav is doing in the Python PR. The Java class has the same name but it's not used by the client.
ConsumerGroupTopicPartitions, add DescribeConsumerGroupsResult
|
Moved to #923, using an internal branch for CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in a draft state because of the fact that librdkafka implementation isn't fully done, and so this should not be merged.
Tested in conjunction with https://github.com/edenhill/librdkafka/tree/feature/list-and-alter-offsets (and depends on this branch).
This includes #852 (by @vsantwana) - the DeleteGroups implementation.
The rest of the bindings are - ListConsumerGroups, DescribeConsumerGroups, AlterConsumerGroupOffsets, and ListConsumerGroupOffsets.
I have some doubts about how I've implemented the options for list/describe consumer groups, so any feedback would be helpful for that