admin-client: Implement DeleteGroups #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks a lot for this PR @vsantwana! Looks good to me, I pulled and tested this locally. We are already in the process of working on several admin api operations for consumer groups as a part of KIP-222. It is important that we review the bindings together, and more importantly release them together, so I will take your commit, and merge it on top of the branch I'm working on for this so I can continue building on top of this. I'll keep cherry-picking any commit you push onto this branch onto my draft, so you can keep pushing any further commits here. You can see and comment on my draft here - #857 - Apart from your commit, I have added a unit test and an example for this feature. |
|
Closing with #923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #826
Follow Up
When the
DescribeGroupapI is available in the Go client, the integration test can be made more concise, without us having to create the second consumer.