2.4.1 backports#341
Conversation
|
Workflow cancelled to save resources |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13092701177. Examine the logs at this URL for more detail. |
h-vetinari
left a comment
There was a problem hiding this comment.
Thanks! I was considering doing this when the queue has cleared up a bit (after all the fixes, tensorflow and pytorch 2.6), especially since there are viable work-arounds in the meantime.
|
no problem ,i have a repo data patch (i think....) |
| - pytorch {{ version }}=cuda*_{{ blas_impl }}*{{ PKG_BUILDNUM }} # [megabuild and cuda_compiler_version != "None"] | ||
| - pytorch {{ version }}=cpu_{{ blas_impl }}*{{ PKG_BUILDNUM }} # [megabuild and cuda_compiler_version == "None"] |
There was a problem hiding this comment.
@h-vetinari i feel like this should actually be
| - pytorch {{ version }}=cuda*_{{ blas_impl }}*{{ PKG_BUILDNUM }} # [megabuild and cuda_compiler_version != "None"] | |
| - pytorch {{ version }}=cpu_{{ blas_impl }}*{{ PKG_BUILDNUM }} # [megabuild and cuda_compiler_version == "None"] | |
| - pytorch {{ version }}=cuda*_{{ blas_impl }}*_{{ PKG_BUILDNUM }} # [megabuild and cuda_compiler_version != "None"] | |
| - pytorch {{ version }}=cpu_{{ blas_impl }}*_{{ PKG_BUILDNUM }} # [megabuild and cuda_compiler_version == "None"] |
There was a problem hiding this comment.
It doesn't make much of a difference (except exercising the new glob-matcher); the build number is always separated from the build hash, so there can be no spurious match even without the underscore. 🤷
There was a problem hiding this comment.
yeah i guess cpu_*5 can't match with cuda126*305
|
With conda-forge/conda-forge-repodata-patches-feedstock#956 merged, there shouldn't be an immediate need for this anymore AFAICT. We did a bunch of relevant backports in #322 and a pinning update in #325, so I think we can probably let |
A few fixes to backport small lifts from the 2.5.X branch back to the 2.4.1 at user requests.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)