Skip to content

Patch pytorch-cpu/gpu for 2.4.1 increased compatibility#956

Merged
h-vetinari merged 1 commit into
conda-forge:mainfrom
hmaarrfk:pytorch_gpu_2.41
Feb 2, 2025
Merged

Patch pytorch-cpu/gpu for 2.4.1 increased compatibility#956
h-vetinari merged 1 commit into
conda-forge:mainfrom
hmaarrfk:pytorch_gpu_2.41

Conversation

@hmaarrfk

@hmaarrfk hmaarrfk commented Feb 1, 2025

Copy link
Copy Markdown
Contributor

xref:


  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk

hmaarrfk commented Feb 1, 2025

Copy link
Copy Markdown
Contributor Author

I don’t think I have the syntax quite right.

I would be ok just patching the 5 series to be honest.

@h-vetinari

Copy link
Copy Markdown
Member

I would be ok just patching the 5 series to be honest.

2.5 is already correct though? Or do you mean old build numbers? I wouldn't bother with those, we want people to use the most recent build numbers anyway.

@hmaarrfk

hmaarrfk commented Feb 1, 2025

Copy link
Copy Markdown
Contributor Author

I mean the 5, 105, 205, 305 build numbers.

Comment thread recipe/patch_yaml/pytorch.yaml Outdated
@hmaarrfk

hmaarrfk commented Feb 2, 2025

Copy link
Copy Markdown
Contributor Author
 python show_diff.py  --use-cache --subdirs linux-64



================================================================================
================================================================================
linux-64
linux-64::pytorch-gpu-2.4.1-cuda120py39h4ea2c68_303.conda
-    "pytorch 2.4.1 cuda120_py39h2e0a0f3_303"
+    "pytorch 2.4.1 cuda120_*_303"
linux-64::pytorch-gpu-2.4.1-cuda118py310h4ecd1fc_301.conda
-    "pytorch 2.4.1 cuda118_py310hd65b3e3_301"
+    "pytorch 2.4.1 cuda118_*_301"
linux-64::pytorch-gpu-2.4.1-cuda120py312h4ea2c68_301.conda
-    "pytorch 2.4.1 cuda120_py312hf8d5e09_301"
+    "pytorch 2.4.1 cuda120_*_301"
linux-64::pytorch-cpu-2.4.1-cpu_mkl_py39h09a6fac_103.conda
-    "pytorch 2.4.1 cpu_mkl_py39ha1b8702_103"
+    "pytorch 2.4.1 cpu_*_103"
linux-64::pytorch-cpu-2.4.1-cpu_generic_py39h6ea6555_5.conda
-    "pytorch 2.4.1 cpu_generic_py39hfbb2c50_5"
+    "pytorch 2.4.1 cpu_*_5"
linux-64::pytorch-cpu-2.4.1-cpu_mkl_py39hd61e0f4_105.conda
-    "pytorch 2.4.1 cpu_mkl_py39hc7b1cc9_105"
+    "pytorch 2.4.1 cpu_*_105"
linux-64::pytorch-gpu-2.4.1-cuda118py310h9e2aef1_304.conda
-    "pytorch 2.4.1 cuda118_py310hb8822b9_304"
+    "pytorch 2.4.1 cuda118_*_304"
linux-64::pytorch-gpu-2.4.1-cuda120py311h7ec93fb_304.conda
-    "pytorch 2.4.1 cuda120_py311h76727f1_304"
+    "pytorch 2.4.1 cuda120_*_304"
linux-64::pytorch-gpu-2.4.1-cuda118py312h9e2aef1_305.conda
-    "pytorch 2.4.1 cuda118_py312h3938941_305"
+    "pytorch 2.4.1 cuda118_*_305"
linux-64::pytorch-cpu-2.4.1-cpu_generic_py310h7a53447_0.conda
-    "pytorch 2.4.1 cpu_generic_py310hcbfaffa_0"
+    "pytorch 2.4.1 cpu_*_0"
linux-64::pytorch-gpu-2.4.1-cuda118py311h4ecd1fc_303.conda
-    "pytorch 2.4.1 cuda118_py311h156befe_303"
+    "pytorch 2.4.1 cuda118_*_303"
linux-64::pytorch-cpu-2.4.1-cpu_mkl_py39h09a6fac_101.conda
-    "pytorch 2.4.1 cpu_mkl_py39h2fcb8f5_101"
+    "pytorch 2.4.1 cpu_*_101"
linux-64::pytorch-cpu-2.4.1-cpu_mkl_py312h09a6fac_102.conda
-    "pytorch 2.4.1 cpu_mkl_py312ha1f5ba4_102"
+    "pytorch 2.4.1 cpu_*_102"
linux-64::pytorch-cpu-2.4.1-cpu_generic_py39h7a53447_3.conda
-    "pytorch 2.4.1 cpu_generic_py39hbaadbe5_3"
+    "pytorch 2.4.1 cpu_*_3"
linux-64::pytorch-gpu-2.4.1-cuda120py39h7ec93fb_305.conda
-    "pytorch 2.4.1 cuda120_py39h752776e_305"
+    "pytorch 2.4.1 cuda120_*_305"
linux-64::pytorch-gpu-2.4.1-cuda118py310h4ecd1fc_300.conda
-    "pytorch 2.4.1 cuda118_py310h22ea9a0_300"
+    "pytorch 2.4.1 cuda118_*_300"
linux-64::pytorch-gpu-2.4.1-cuda120py312h4ea2c68_302.conda
-    "pytorch 2.4.1 cuda120_py312hf8d5e09_302"
+    "pytorch 2.4.1 cuda120_*_302"
linux-64::pytorch-cpu-2.4.1-cpu_generic_py310h6ea6555_4.conda
-    "pytorch 2.4.1 cpu_generic_py310he25a6ea_4"
+    "pytorch 2.4.1 cpu_*_4"
linux-64::pytorch-cpu-2.4.1-cpu_generic_py312h7a53447_1.conda
-    "pytorch 2.4.1 cpu_generic_py312h916ba9d_1"
+    "pytorch 2.4.1 cpu_*_1"
linux-64::pytorch-cpu-2.4.1-cpu_mkl_py313hd61e0f4_104.conda
-    "pytorch 2.4.1 cpu_mkl_py313hb07d3e6_104"
+    "pytorch 2.4.1 cpu_*_104"
linux-64::pytorch-cpu-2.4.1-cpu_generic_py313h7a53447_2.conda
-    "pytorch 2.4.1 cpu_generic_py313h30720f7_2"
+    "pytorch 2.4.1 cpu_*_2"
linux-64::pytorch-gpu-2.4.1-cuda118py312h4ecd1fc_302.conda
-    "pytorch 2.4.1 cuda118_py312h1e5d2cd_302"
+    "pytorch 2.4.1 cuda118_*_302"
linux-64::pytorch-gpu-2.4.1-cuda120py312h4ea2c68_300.conda
-    "pytorch 2.4.1 cuda120_py312h257e401_300"
+    "pytorch 2.4.1 cuda120_*_300"
linux-64::pytorch-cpu-2.4.1-cpu_mkl_py312h09a6fac_100.conda
-    "pytorch 2.4.1 cpu_mkl_py312hf535c18_100"
+    "pytorch 2.4.1 cpu_*_100"

@hmaarrfk hmaarrfk marked this pull request as ready for review February 2, 2025 00:47
@hmaarrfk hmaarrfk requested a review from a team as a code owner February 2, 2025 00:47
Comment thread recipe/patch_yaml/pytorch.yaml

@h-vetinari h-vetinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@h-vetinari h-vetinari merged commit 5fb08fa into conda-forge:main Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants