Skip to content

Enable Linux ARM builds#5

Closed
conda-forge-admin wants to merge 7 commits intoconda-forge:mainfrom
conda-forge-admin:conda_forge_admin_4
Closed

Enable Linux ARM builds#5
conda-forge-admin wants to merge 7 commits intoconda-forge:mainfrom
conda-forge-admin:conda_forge_admin_4

Conversation

@conda-forge-admin
Copy link
Copy Markdown
Contributor

@conda-forge-admin conda-forge-admin commented Apr 13, 2023 •
edited by jakirkham
Loading

Configures the feedstock for Linux ARM (linux_aarch64) builds.

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #4.

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #4
Fixes #6

@conda-forge-webservices conda-forge-webservices Bot mentioned this pull request Apr 13, 2023
Closed
@conda-forge-webservices
Copy link
Copy Markdown
Contributor

conda-forge-webservices Bot commented Apr 13, 2023

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 3 commits April 13, 2023 06:02
@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Apr 13, 2023

@conda-forge-admin, please re-render

@jakirkham jakirkham changed the title MNT: rerender Enable Linux ARM builds Apr 13, 2023
@jakirkham jakirkham mentioned this pull request Apr 13, 2023
Closed
@jakirkham
Fix platform for Linux ARM
ddb0caf 
Appears `linux_aarch64` is used in the URL. So update the `platform`
accordingly.
@jakirkham
Skip libcufile_rdma on linux_aarch64
219f1fd 
The `libcufile_rdma` library isn't included in the `redist` for
`linux_aarch64`. So skip it. Looks like this was skipped in a few place
not all. This adds the remaining selectors to restrict `libcufile_rdma`
checks to `linux64`.
jakirkham
jakirkham reviewed Apr 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to fix a few things to get Linux ARM builds working. Have called out the changes below

Would be good to confirm these are expected

Comment thread recipe/meta.yaml
{% set cuda_version = "12.0" %}
{% set platform = "linux-x86_64" %} # [linux64]
{% set platform = "linux-sbsa" %} # [aarch64]
{% set platform = "linux-aarch64" %} # [aarch64]
Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks lie the redist URL uses linux-aarch64. There isn't a linux-sbsa in this case. Might be worth double checking this is expected

Copy link
Copy Markdown
Contributor

@bdice bdice Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adibbley Can you comment on this? Just making sure -- this is SBSA compatible and not L4T / Jetson, right?

Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( answered in the summary below: #5 (review) )

Comment thread recipe/meta.yaml
commands:
- test -L $PREFIX/lib/libcufile.so
- test -L $PREFIX/lib/libcufile_rdma.so
- test -L $PREFIX/lib/libcufile_rdma.so # [linux64]
Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears libcufile_rdma.so is absent from the linux_aarch64 redist. So restricting this test to linux64.

Comment thread recipe/meta.yaml
- test -f $PREFIX/targets/{{ target_name }}/include/cufile.h
- test -L $PREFIX/targets/{{ target_name }}/lib/libcufile.so
- test -L $PREFIX/targets/{{ target_name }}/lib/libcufile_rdma.so
- test -L $PREFIX/targets/{{ target_name }}/lib/libcufile_rdma.so # [linux64]
Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Comment thread recipe/meta.yaml
commands:
- test -f $PREFIX/targets/{{ target_name }}/lib/libcufile_static.a
- test -f $PREFIX/targets/{{ target_name }}/lib/libcufile_rdma_static.a
- test -f $PREFIX/targets/{{ target_name }}/lib/libcufile_rdma_static.a # [linux64]
Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly the libcufile_rdma_static.a is absent from the linux_aarch64 redist. So restricting this test to linux64 as well.

@jakirkham jakirkham marked this pull request as draft April 13, 2023 16:15
bdice
bdice requested changes Apr 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion with @adibbley, this build of libcufile is targeting L4T and not ARM SBSA. We can't package this for conda-forge aarch64 (which is SBSA), at least with CUDA 12.0-12.1.

@jakirkham jakirkham mentioned this pull request Dec 18, 2023
Merged
@adibbley adibbley closed this in #9 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham jakirkham left review comments

@bdice bdice bdice requested changes

@adibbley adibbley Awaiting requested review from adibbley

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add linux_aarch64 packages @conda-forge-admin, please re-render

3 participants

@conda-forge-admin @jakirkham @bdice