Skip to content

Enable Linux ARM builds #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
conda-forge-admin wants to merge 7 commits into from
Closed

Enable Linux ARM builds #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f2f8f73
dummy commit for rerendering
conda-forge-webservices[bot] Apr 13, 2023
33ce506
MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and co…
Apr 13, 2023
f7bf4f1
Reorder `conda-forge.yml` sections
jakirkham Apr 13, 2023
d55f9e8
Enable `linux_aarch64` builds
jakirkham Apr 13, 2023
e3386d3
MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and co…
Apr 13, 2023
ddb0caf
Fix `platform` for Linux ARM
jakirkham Apr 13, 2023
219f1fd
Skip `libcufile_rdma` on `linux_aarch64`
jakirkham Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .ci_support/linux_aarch64_.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
BUILD:
- aarch64-conda_cos7-linux-gnu
arm_variant_type:
- sbsa
c_compiler:
- gcc
c_compiler_version:
- '11'
cdt_arch:
- aarch64
cdt_name:
- cos7
channel_sources:
- conda-forge
channel_targets:
- conda-forge main
cxx_compiler:
- gxx
cxx_compiler_version:
- '11'
docker_image:
- quay.io/condaforge/linux-anvil-aarch64
target_platform:
- linux-aarch64
zip_keys:
- - c_compiler_version
- cxx_compiler_version
22 changes: 22 additions & 0 deletions .travis.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 15 additions & 1 deletion README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions conda-forge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
github:
branch_name: main
tooling_branch_name: main
conda_build:
error_overlinking: true
conda_forge_output_validation: true
github:
branch_name: main
tooling_branch_name: main
os_version:
linux_64: cos7
provider:
linux_aarch64: default
8 changes: 4 additions & 4 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{% set version = "1.5.0.59" %}
{% set cuda_version = "12.0" %}
{% set platform = "linux-x86_64" %} # [linux64]
{% set platform = "linux-sbsa" %} # [aarch64]
{% set platform = "linux-aarch64" %} # [aarch64]
Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks lie the redist URL uses linux-aarch64. There isn't a linux-sbsa in this case. Might be worth double checking this is expected

Copy link
Copy Markdown
Contributor

@bdice bdice Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adibbley Can you comment on this? Just making sure -- this is SBSA compatible and not L4T / Jetson, right?

Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( answered in the summary below: #5 (review) )

{% set target_name = "x86_64-linux" %} # [linux64]
{% set target_name = "sbsa-linux" %} # [aarch64]
{% set extension = "tar.xz" %} # [not win]
Expand Down Expand Up @@ -97,10 +97,10 @@ outputs:
test:
commands:
- test -L $PREFIX/lib/libcufile.so
- test -L $PREFIX/lib/libcufile_rdma.so
- test -L $PREFIX/lib/libcufile_rdma.so # [linux64]
Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears libcufile_rdma.so is absent from the linux_aarch64 redist. So restricting this test to linux64.

- test -f $PREFIX/targets/{{ target_name }}/include/cufile.h
- test -L $PREFIX/targets/{{ target_name }}/lib/libcufile.so
- test -L $PREFIX/targets/{{ target_name }}/lib/libcufile_rdma.so
- test -L $PREFIX/targets/{{ target_name }}/lib/libcufile_rdma.so # [linux64]
Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

- test -d $PREFIX/man/man3
about:
home: https://developer.nvidia.com/cuda-toolkit
Expand Down Expand Up @@ -130,7 +130,7 @@ outputs:
test:
commands:
- test -f $PREFIX/targets/{{ target_name }}/lib/libcufile_static.a
- test -f $PREFIX/targets/{{ target_name }}/lib/libcufile_rdma_static.a
- test -f $PREFIX/targets/{{ target_name }}/lib/libcufile_rdma_static.a # [linux64]
Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly the libcufile_rdma_static.a is absent from the linux_aarch64 redist. So restricting this test to linux64 as well.

about:
home: https://developer.nvidia.com/cuda-toolkit
license: LicenseRef-NVIDIA-End-User-License-Agreement
Expand Down