Skip to content

Update for CUDA 12.2.2#9

Merged
adibbley merged 5 commits intoconda-forge:mainfrom
adibbley:cuda-12.2.2
Dec 19, 2023
Merged

Update for CUDA 12.2.2#9
adibbley merged 5 commits intoconda-forge:mainfrom
adibbley:cuda-12.2.2

Conversation

@adibbley
Copy link
Copy Markdown
Contributor

@adibbley adibbley commented Dec 18, 2023

xref: conda-forge/cuda-feedstock#13

Fixes #6
Closes #5

@conda-forge-webservices
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@adibbley
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@jakirkham
Copy link
Copy Markdown
Member

There were some changes in PR ( #5 ), which may be useful

Should avoid no-op bot PRs that just reorder this file.
@jakirkham
Copy link
Copy Markdown
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libcufile-feedstock/actions/runs/7260492823.

@jakirkham
Copy link
Copy Markdown
Member

@conda-forge-admin, please restart CI

@jakirkham jakirkham marked this pull request as ready for review December 19, 2023 10:26
@jakirkham jakirkham requested a review from a team as a code owner December 19, 2023 10:26
@jakirkham jakirkham added the automerge Merge the PR when CI passes label Dec 19, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: failed
  • azure: failed

Thus the PR was not passing and not merged.

@jakirkham jakirkham removed the automerge Merge the PR when CI passes label Dec 19, 2023
@jakirkham
Copy link
Copy Markdown
Member

CI is failing as this patch no longer applies

--- samples/Makefile 2022-06-24 00:23:23.000000000 +0000
+++ samples/Makefile.new 2022-06-27 15:04:32.235125647 +0000
@@ -35,8 +35,8 @@
# Common includes and paths for CUDA
-CUDA_PATH := /usr/local/cuda
-CUFILE_PATH ?= /usr/local/cuda/targets/x86_64-linux/lib/
-CUFILE_INCLUDE_PATH ?= /usr/local/cuda/targets/x86_64-linux/include/
+CUDA_PATH := ${PREFIX}
+CUFILE_PATH ?= $(CUDA_PATH)/targets/x86_64-linux/lib/
+CUFILE_INCLUDE_PATH ?= $(CUDA_PATH)/targets/x86_64-linux/include/
CXXFLAGS := -Wall
CXXFLAGS += -I $(CUDA_PATH)/include/
CXXFLAGS += -I $(CUFILE_INCLUDE_PATH)

Do we still need it? If so, does it need an update?

@jakirkham jakirkham marked this pull request as draft December 19, 2023 10:36
@adibbley adibbley marked this pull request as ready for review December 19, 2023 17:21
@adibbley adibbley merged commit 8a4a3b2 into conda-forge:main Dec 19, 2023
@jakirkham
Copy link
Copy Markdown
Member

Thanks Alex! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add linux_aarch64 packages

2 participants