Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes support for 1.16 and up #10

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

ramonskie
Copy link
Contributor

@ramonskie ramonskie commented Nov 5, 2019

add support for kuberntes 1.16 and up
also backwards compatible.
see #9

dupe of helm/charts#18557

i also needed to define the selector see helm/charts#7726

have not tested an upgrade scenario.
see selector issues

@cirocosta
Copy link
Member

Hey @ramonskie,

thank you very much for the PR!

have not tested an upgrade scenario.

Is that something we should worry about? I've never seen the effects of changing
from a controller to another 🤔 (having never gone through an upgrade
like this).


Also, We're still finalizing some of the details of migrating ourselves out of
helm/charts into this repo (e.g., we want to have a pipeline that runs our e2e
tests, etc), so it might take a little while until we properly get this PR in
😬

thank you!

@ozzywalsh
Copy link

Is this going to be merged & released soon?
We have updated to 1.16 and cannot use the Concourse chart at the moment.

@Rambatino
Copy link

I too am struggling. More and more people are going to stumble upon this because of this error:

Error: validation failed: [unable to recognize "": no matches for kind "Deployment" in version "extensions/v1beta1", unable to recognize "": no matches for kind "StatefulSet" in version "apps/v1beta2", unable to recognize "": no matches for kind "StatefulSet" in version "apps/v1beta1"]

It means that you cannot install the concourse helm chart on Kubernetes 1.16

@gowrisankar22
Copy link
Contributor

@ramonskie I also, ran into the same issue but I made changes locally adapting to 1.16 and running. Maybe you can run also run the same way until this is merged.

Copy link
Member

@taylorsilva taylorsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this now. Sorry this took so long. We'll get this published on our chart repo sometime this week.

@taylorsilva taylorsilva merged commit c13f142 into concourse:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants