Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/concourse] migrate API versions from deprecated, removed versions #18803

Closed
wants to merge 1 commit into from
Closed

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Nov 12, 2019

Signed-off-by: Naoki Oketani [email protected]

Is this a new chart

No

What this PR does / why we need it:

In k8s v1.16 some APIs are deprecated and removed.
https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

As a result, installation failed. I migrate to use supported API versions.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oke-py
To complete the pull request process, please assign youssb
You can assign the PR to them by writing /assign @youssb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @oke-py. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 12, 2019
@oke-py
Copy link
Contributor Author

oke-py commented Nov 12, 2019

/assign @YoussB

@YoussB
Copy link
Collaborator

YoussB commented Nov 12, 2019

Hey @oke-py,
Thanks for the pr.
We're moving the concourse chart to https://github.com/concourse/concourse-chart
do you mind opening the pr their, if needed
thx!

@oke-py
Copy link
Contributor Author

oke-py commented Nov 13, 2019

concourse/concourse-chart#10 will resolve this. I close this PR.

@oke-py oke-py closed this Nov 13, 2019
@oke-py oke-py deleted the concourse branch November 13, 2019 07:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stable/concourse] chart is incompatible with k8s v1.16.
4 participants