Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

concourse - support kubernetes 1.16 and up #18557

Closed
wants to merge 1 commit into from

Conversation

ramonskie
Copy link

support kubernetes 1.16 and higher

i needed to add the selector see
#7726

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ramonskie
To complete the pull request process, please assign youssb
You can assign the PR to them by writing /assign @youssb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @ramonskie. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2019
@ramonskie
Copy link
Author

there is still an issue where it creates a second namespace *-main and its empty not sure where its coming from.

@zanhsieh
Copy link
Collaborator

zanhsieh commented Nov 5, 2019

@ramonskie
Could you sign DCO and bump chart to latest version please?

@ramonskie
Copy link
Author

this pr can be closed as its moved to concourse/concourse-chart#10

@ramonskie ramonskie closed this Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants