Skip to content

wasmedge - fix YML linter (conandata.yml)#12768

Merged
conan-center-bot merged 3 commits into
conan-io:masterfrom
jgsogo:linter/yaml-wasmedge
Sep 2, 2022
Merged

wasmedge - fix YML linter (conandata.yml)#12768
conan-center-bot merged 3 commits into
conan-io:masterfrom
jgsogo:linter/yaml-wasmedge

Conversation

@jgsogo
Copy link
Copy Markdown
Contributor

@jgsogo jgsogo commented Sep 1, 2022

While I wait for this PR to pass, let's do some housecleaning.

@jgsogo jgsogo marked this pull request as ready for review September 1, 2022 11:59
@conan-center-bot

This comment has been minimized.

Comment thread recipes/wasmedge/all/conandata.yml Outdated
@@ -1,5 +1,18 @@
sources:
"0.10.0":
# Macos:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be removed as it's commented. Also, could replace tabs by spaces.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see tabs in this file... 🤔

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github diff makes me crazy ... Space it uses dots, Tabs is uses arrow, but also nothing sometimes ... I thought it was mixed. Nevermid.

Please, remove commented versions. User could open issues related to a not built version but listed in conandata.

@conan-center-bot
Copy link
Copy Markdown
Contributor

All green in build 3 (35795cf39a231c6e0fd5639053e59536a91f8632):

  • wasmedge/0.9.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12768/recipes/wasmedge/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12768/recipes/wasmedge/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12768/recipes/wasmedge/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • wasmedge/0.10.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12768/recipes/wasmedge/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12768/recipes/wasmedge/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12768/recipes/wasmedge/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • wasmedge/0.9.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12768/recipes/wasmedge/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12768/recipes/wasmedge/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12768/recipes/wasmedge/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@prince-chrismc
Copy link
Copy Markdown
Contributor

Could we stuff something like https://stackoverflow.com/a/46626418 into the conandata linter? 🙏

I noticed a handful of projects have really bizarre data ... I looked in the repo and got ~50 results **self.conan_data["sources"][self.version][ (notice the extra [) not sure how creative people should be 🙊

@jgsogo
Copy link
Copy Markdown
Contributor Author

jgsogo commented Sep 2, 2022

@prince-chrismc , are you talking about YML schema validation? Like #11150? I'm a huge fan of schema validation (and strong typed languages, and SQL,... 😄 ), but the library I found didn't provide a parseable output. I'm sure there are other libraries, or maybe we can contribute the output to that one.

btw, hooks already provide some schema validation

@uilianries
Copy link
Copy Markdown
Member

I would prefer a Conan tool which copy patches. It's the same pattern ever.

@conan-center-bot conan-center-bot merged commit 94d5ef5 into conan-io:master Sep 2, 2022
@jgsogo jgsogo deleted the linter/yaml-wasmedge branch September 2, 2022 10:54
@prince-chrismc
Copy link
Copy Markdown
Contributor

but the library I found didn't provide a parseable output

Hmmmm, 🤔 what exactly were you looking for? Like something we could have annotations from?

Hmm I might fool around with your code and see of I can find anything different

@jgsogo
Copy link
Copy Markdown
Contributor Author

jgsogo commented Sep 5, 2022

We need a library/app to validate a YML schema, and with a parseable output so we can provide the warnings/errors to users like we are doing with the linter (output should contain file + line + message)

ericLemanissier pushed a commit to ericLemanissier/cocorepo that referenced this pull request Sep 26, 2022
* wasmedge - fix YML linter (conandata.yml)

* move things, just because of linter-comment rules

* remove commented sections, as per review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants