wasmedge - fix YML linter (conandata.yml)#12768
Conversation
This comment has been minimized.
This comment has been minimized.
| @@ -1,5 +1,18 @@ | |||
| sources: | |||
| "0.10.0": | |||
| # Macos: | |||
There was a problem hiding this comment.
It can be removed as it's commented. Also, could replace tabs by spaces.
There was a problem hiding this comment.
I don't see tabs in this file... 🤔
There was a problem hiding this comment.
Github diff makes me crazy ... Space it uses dots, Tabs is uses arrow, but also nothing sometimes ... I thought it was mixed. Nevermid.
Please, remove commented versions. User could open issues related to a not built version but listed in conandata.
|
All green in build 3 (
|
|
Could we stuff something like https://stackoverflow.com/a/46626418 into the conandata linter? 🙏 I noticed a handful of projects have really bizarre data ... I looked in the repo and got ~50 results |
|
@prince-chrismc , are you talking about YML schema validation? Like #11150? I'm a huge fan of schema validation (and strong typed languages, and SQL,... 😄 ), but the library I found didn't provide a parseable output. I'm sure there are other libraries, or maybe we can contribute the output to that one. btw, hooks already provide some schema validation |
|
I would prefer a Conan tool which copy patches. It's the same pattern ever. |
Hmmmm, 🤔 what exactly were you looking for? Like something we could have annotations from? Hmm I might fool around with your code and see of I can find anything different |
|
We need a library/app to validate a YML schema, and with a parseable output so we can provide the warnings/errors to users like we are doing with the linter (output should contain file + line + message) |
* wasmedge - fix YML linter (conandata.yml) * move things, just because of linter-comment rules * remove commented sections, as per review
While I wait for this PR to pass, let's do some housecleaning.