[schema] Validate config and conandata schemas (incomplete)#11150
Closed
jgsogo wants to merge 2 commits into
Closed
[schema] Validate config and conandata schemas (incomplete)#11150jgsogo wants to merge 2 commits into
jgsogo wants to merge 2 commits into
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Belongs to the same initiative as #11147, a way to provide better and easier-to-understand feedback to users.
This is exploratory. Validating a schema is much harder and rules are usually more complicated than a linter... but declaring a schema is usually simpler than implementing the checks.
I found this library https://github.com/Grokzen/pykwalify with some documentation https://pykwalify.readthedocs.io/en/unstable/validation-rules.html
The library doesn't have any parseable output that we could use to report the errors in the PR itself (with a GH problem-matcher), maybe we should contribute that output if we really want to use it.