[linter] Add rule about importing tools from conan module#12765
Merged
Conversation
This was referenced Sep 1, 2022
Contributor
Author
|
Please, @AndreyMlashkin, have a look at this rule. It needs to be implemented in your script, or the linter will complain. Thanks. |
Contributor
|
My script is based on simple find and replace patterns and here some more complex logic is needed, so, I don't think it is possible to automate migration, that fulfil this rule... |
Member
|
@AndreyMlashkin, please, provide a separated project in Github for your script if possible, it will help to receive new PRs, and post its link when opening a new PR on the description. I could check during the weekend, there is no big deal replacing words. |
ericLemanissier
pushed a commit
to ericLemanissier/cocorepo
that referenced
this pull request
Sep 26, 2022
…odule * [linter] Add rule about importing tools from conan module * allow from conan.tools import xxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforcing documented ways to import tools: https://docs.conan.io/en/latest/reference/conanfile/tools.html. Everything else is considered not-stable.
Only 44 recipes are affected, not bad: