Skip to content

migrate heatshrink to conan v2#12745

Closed
AndreyMlashkin wants to merge 1 commit into
conan-io:masterfrom
AndreyMlashkin:migrate_heatshrink_to_conan_v2_try10
Closed

migrate heatshrink to conan v2#12745
AndreyMlashkin wants to merge 1 commit into
conan-io:masterfrom
AndreyMlashkin:migrate_heatshrink_to_conan_v2_try10

Conversation

@AndreyMlashkin

Copy link
Copy Markdown
Contributor

This conan v2 migration PR was generated by automatoc script version 10.
It uses simple find and replace technics. Feel free to extend it.

@conan-center-bot

This comment has been minimized.

@uilianries uilianries left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, take into account the tools guidelines for your script

docs.conan.io/en/latest/reference/conanfile/tools.html

@prince-chrismc

Copy link
Copy Markdown
Contributor

this rule is being enforced FYI #12765

@uilianries uilianries closed this Sep 2, 2022
@uilianries uilianries reopened this Sep 2, 2022
@uilianries uilianries self-requested a review September 2, 2022 10:01
@conan-center-bot

Copy link
Copy Markdown
Contributor

All green in build 2 (527d165badbf4f6058407b763fba3392b4c90dc9):

  • heatshrink/0.4.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12745/recipes/heatshrink/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12745/recipes/heatshrink/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12745/recipes/heatshrink/all/conanfile.py", line 4, in <module>
        from conans import CMake
    ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@prince-chrismc

Copy link
Copy Markdown
Contributor

Since this was generated by a script and it requires manual intervention to get going, I am going to close this PR

Feel free to re-open if you'd like to address the comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants