fix MakeFunctionCallable's codegen for templated operators
#509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
+ Coverage 71.63% 72.33% +0.69%
==========================================
Files 9 9
Lines 3568 3575 +7
==========================================
+ Hits 2556 2586 +30
+ Misses 1012 989 -23
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| auto* TOperatorCtor = Cpp::GetDefaultConstructor(TOperator); | ||
| auto FCI_TOperatorCtor = Cpp::MakeFunctionCallable(TOperatorCtor); | ||
| void* toperator = nullptr; | ||
| FCI_TOperatorCtor.Invoke((void*)&toperator); |
Contributor
There was a problem hiding this comment.
warning: multilevel pointer conversion from 'void **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion]
FCI_TOperatorCtor.Invoke((void*)&toperator);
^
Vipul-Cariappa
deleted the
dev/templated-operator-makecallable-codegen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes code generation of
MakeFunctionCallablefor templated operators.Look at the inline comment.
Fixes # (issue)
Fixes one test case in cppyy.
Please tick all options which are relevant.
Testing
Tests included.
Checklist