chore: rename weather editor to CS editor #2449
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR renames WeatherEditor to CSEditor across code, menus, blur control, global registration, editor window wiring, dependent features, and documentation while preserving existing behavior. ChangesCSEditor Feature Branding Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Actionable Suggestions
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/Menu.cpp (1)
345-366:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPreserve existing
WeatherEditorToggleKeyconfigs during the rename.This load path only reads
CSEditorToggleKey, so upgraded installs with a savedWeatherEditorToggleKeywill silently fall back to the default binding and lose their custom editor hotkey.Proposed fix
migrateKey(o_json, "ToggleKey", settings.ToggleKey); migrateKey(o_json, "SkipCompilationKey", settings.SkipCompilationKey); migrateKey(o_json, "EffectToggleKey", settings.EffectToggleKey); migrateKey(o_json, "OverlayToggleKey", settings.OverlayToggleKey); migrateKey(o_json, "ShaderBlockPrevKey", settings.ShaderBlockPrevKey); migrateKey(o_json, "ShaderBlockNextKey", settings.ShaderBlockNextKey); + if (!o_json.contains("CSEditorToggleKey") && o_json.contains("WeatherEditorToggleKey")) { + o_json["CSEditorToggleKey"] = o_json["WeatherEditorToggleKey"]; + } migrateKey(o_json, "CSEditorToggleKey", settings.CSEditorToggleKey); migrateKey(o_json, "ScreenshotKey", settings.ScreenshotKey);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/Menu.cpp` around lines 345 - 366, The code only loads "CSEditorToggleKey" into settings.CSEditorToggleKey, so existing installs that still have "WeatherEditorToggleKey" will be ignored; update the load path (e.g. inside or alongside loadComboList usage for "CSEditorToggleKey") to also check for "WeatherEditorToggleKey" and, if present, deserialize it into the same target (settings.CSEditorToggleKey) or call migrateKey("WeatherEditorToggleKey", settings.CSEditorToggleKey) before/if loading "CSEditorToggleKey" so user-configured WeatherEditorToggleKey bindings are preserved when renaming; keep existing try/catch logging behavior from loadComboList.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/Menu.cpp`:
- Around line 345-366: The code only loads "CSEditorToggleKey" into
settings.CSEditorToggleKey, so existing installs that still have
"WeatherEditorToggleKey" will be ignored; update the load path (e.g. inside or
alongside loadComboList usage for "CSEditorToggleKey") to also check for
"WeatherEditorToggleKey" and, if present, deserialize it into the same target
(settings.CSEditorToggleKey) or call migrateKey("WeatherEditorToggleKey",
settings.CSEditorToggleKey) before/if loading "CSEditorToggleKey" so
user-configured WeatherEditorToggleKey bindings are preserved when renaming;
keep existing try/catch logging behavior from loadComboList.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: bcc644ec-292f-48ba-9eeb-9d61748d5af3
📒 Files selected for processing (50)
docs/weather-system-docs/WeatherVariableRegistration.mdfeatures/CS Editor/COREfeatures/CS Editor/Shaders/Features/CSEditor.inisrc/CSEditor/EditorWindow.cppsrc/CSEditor/EditorWindow.hsrc/CSEditor/InteriorOnlyPanel.cppsrc/CSEditor/InteriorOnlyPanel.hsrc/CSEditor/LightEditor.cppsrc/CSEditor/LightEditor.hsrc/CSEditor/PaletteWindow.cppsrc/CSEditor/PaletteWindow.hsrc/CSEditor/Weather/CellLightingWidget.cppsrc/CSEditor/Weather/CellLightingWidget.hsrc/CSEditor/Weather/ImageSpaceWidget.cppsrc/CSEditor/Weather/ImageSpaceWidget.hsrc/CSEditor/Weather/LensFlareWidget.cppsrc/CSEditor/Weather/LensFlareWidget.hsrc/CSEditor/Weather/LightingTemplateWidget.cppsrc/CSEditor/Weather/LightingTemplateWidget.hsrc/CSEditor/Weather/PrecipitationWidget.cppsrc/CSEditor/Weather/PrecipitationWidget.hsrc/CSEditor/Weather/ReferenceEffectWidget.cppsrc/CSEditor/Weather/ReferenceEffectWidget.hsrc/CSEditor/Weather/SimpleFormWidget.hsrc/CSEditor/Weather/VolumetricLightingWidget.cppsrc/CSEditor/Weather/VolumetricLightingWidget.hsrc/CSEditor/Weather/WeatherWidget.cppsrc/CSEditor/Weather/WeatherWidget.hsrc/CSEditor/WeatherUtils.cppsrc/CSEditor/WeatherUtils.hsrc/CSEditor/Widget.cppsrc/CSEditor/Widget.hsrc/Deferred.cppsrc/Feature.cppsrc/Features/CSEditor.cppsrc/Features/CSEditor.hsrc/Features/InverseSquareLighting.cppsrc/Features/WetnessEffects.cppsrc/Globals.cppsrc/Globals.hsrc/Menu.cppsrc/Menu.hsrc/Menu/BackgroundBlur.cppsrc/Menu/BackgroundBlur.hsrc/Menu/HomePageRenderer.cppsrc/Menu/OverlayRenderer.cppsrc/Menu/SettingsTabRenderer.cppsrc/Menu/SettingsTabRenderer.hsrc/State.cppsrc/Utils/UI.cpp
|
✅ A pre-release build is available for this PR: |
2e57080
into
community-shaders:dev
Summary by CodeRabbit