fix: revert TAA shader#2375
Closed
doodlum wants to merge 3 commits into
Closed
Conversation
|
No actionable suggestions for changed features. |
Contributor
📝 WalkthroughWalkthroughReplaces ISTemporalAA.hlsl PS with a decompiled, register-heavy implementation (fixed registers, new cb12, HDR convert helpers, and a void entry writing SV_Target0/1) and adds an early-return in ShaderCache to disable this imagespace shader in VR. ChangesTemporal AA Shader Update and VR Control
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package/Shaders/ISTemporalAA.hlsl (1)
19-27: ⚡ Quick winName the load-bearing cbuffer slots.
cb2[3],cb2[4],cb2[5],cb12[43], andcb12[44]now drive most of the UV clamping and blend logic, but the raw indices make the binding contract very hard to audit in the next edit. A few declaration-site comments or aliases would make this much safer to maintain.Suggested minimal cleanup
cbuffer cb2 : register(b2) { - float4 cb2[6]; + float4 cb2[6]; // [3]=taa offsets, [4]=blend/sharpen params, [5].w=history threshold } cbuffer cb12 : register(b12) { - float4 cb12[45]; + float4 cb12[45]; // [43]=UV scale/bounds, [44].zw=screen clamp bounds }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package/Shaders/ISTemporalAA.hlsl` around lines 19 - 27, The anonymous constant buffer entries cb2 and cb12 are used by magic indices (cb2[3], cb2[4], cb2[5], cb12[43], cb12[44]) which makes bindings hard to audit; update the declaration of cb2 and cb12 in ISTemporalAA.hlsl by adding clear declaration-site comments or named aliases describing what those specific slots represent (e.g., uvClampMin, uvClampMax, blendParams, historyWeightX, historyWeightY) and/or introduce simple const aliases or struct wrappers that map cb2[3]/[4]/[5] and cb12[43]/[44] to meaningful names so future editors can see the binding contract at the buffer definition.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package/Shaders/ISTemporalAA.hlsl`:
- Around line 19-27: The anonymous constant buffer entries cb2 and cb12 are used
by magic indices (cb2[3], cb2[4], cb2[5], cb12[43], cb12[44]) which makes
bindings hard to audit; update the declaration of cb2 and cb12 in
ISTemporalAA.hlsl by adding clear declaration-site comments or named aliases
describing what those specific slots represent (e.g., uvClampMin, uvClampMax,
blendParams, historyWeightX, historyWeightY) and/or introduce simple const
aliases or struct wrappers that map cb2[3]/[4]/[5] and cb12[43]/[44] to
meaningful names so future editors can see the binding contract at the buffer
definition.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 90564010-d006-4637-af31-e0a07d48a4f0
📒 Files selected for processing (2)
package/Shaders/ISTemporalAA.hlslsrc/ShaderCache.cpp
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package/Shaders/ISTemporalAA.hlsl`:
- Around line 29-32: The cbuffer declaration "cbuffer cb12 { float4 cb12[45]; }"
is missing the required trailing semicolon; update the cbuffer block for cb12 by
appending a semicolon after the closing brace (i.e., after "}" in the cbuffer
cb12 declaration) so the HLSL shader compiles correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d7ed0512-2594-45ab-8be7-3914932f2a94
📒 Files selected for processing (1)
package/Shaders/ISTemporalAA.hlsl
|
✅ A pre-release build is available for this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2371
Summary by CodeRabbit
Bug Fixes
Refactor