fix(VR): disable broken HDR shader ISTemporalAA

[alandtse]

Summary by CodeRabbit

• Bug Fixes
  • Improved temporal anti-aliasing shader resolution on non-VR builds.

[coderabbitai]

📝 Walkthrough

Walkthrough

The GetImagespaceShaderDescriptor function in ShaderCache.cpp now includes platform-specific handling for the temporal anti-aliasing imagespace shader, short-circuiting resolution on non-VR builds by directly querying the ImageSpaceManager instead of using the descriptor map.

Changes

Cohort / File(s)	Summary
Imagespace Shader Descriptor Resolution src/ShaderCache.cpp	Added conditional logic to handle "BSImagespaceShaderISTemporalAA" resolution on non-VR builds by retrieving the descriptor directly from ImageSpaceManager::GetCurrentIndex(ISTemporalAA). Removed the corresponding unconditional map entry for this shader name.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix(VR): use only supported shaders from cache #1553: Adds a ResolveImageSpaceDescriptor helper function and centralizes descriptor resolution checks in the same file, directly intersecting with this shader descriptor resolution logic.
• perf: use unordered_dense maps, misc optimisation #1279: Modifies the descriptors map container type in the same function, affecting the descriptor lookup mechanism that this PR alters.

Suggested reviewers

• jiayev
• doodlum

Poem

🐰 A shader for a world less warped by glass,
Temporal AA now knows where it stands,
On solid ground, not VR's swaying dance,
Swift short-circuits let the pixels prance—
Reality refreshed with whisker-sniff finesse! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: disabling the ISTemporalAA shader for non-VR builds where it's broken, directly reflecting the code modification.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/ShaderCache.cpp`:
- Around line 1646-1649: The current early return in
ResolveImageSpaceDescriptor() unconditionally skips custom VR handling for
imagespaceShader.name == "BSImagespaceShaderISTemporalAA" when
REL::Module::IsVR() is true, which breaks all VR TAA descriptor resolution;
change the condition so the early-out only occurs when the HDR-specific variant
is in effect (e.g., combine REL::Module::IsVR() && strcmp(imagespaceShader.name,
"BSImagespaceShaderISTemporalAA") == 0 with a check for the HDR feature state
such as globals::features::hdrDisplay.loaded), or move the bypass to the
HDR-specific call site, ensuring ISTemporalAA (and descriptors lookup) continues
to be resolved for other VR uses and ResolveImageSpaceDescriptor()/descriptors
retrieval still runs when HDR is not loaded.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5360134e-6d16-4ed0-821a-13e36d79d0a0

📥 Commits

Reviewing files that changed from the base of the PR and between 6e4cd11 and 8076d87.

📒 Files selected for processing (1)

• src/ShaderCache.cpp

[github-actions]

✅ A pre-release build is available for this PR:
Download