fix(TAA): flicker

[alandtse]

Summary by CodeRabbit

• Improvements
  • Enhanced temporal anti-aliasing for more stable and accurate blending across frames, improving edge stability and reducing flicker.
  • Refined luminance-based clamping and neighbor blending to better preserve detail and avoid over-darkening.
  • Adjusted transparency handling to prevent incorrect alpha-driven blending artifacts.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bb227b13-85e9-4bd4-9f35-33dfc918ab81

📥 Commits

Reviewing files that changed from the base of the PR and between cfb3d22 and 0549acf.

📒 Files selected for processing (1)

• package/Shaders/ISTemporalAA.hlsl

✅ Files skipped from review due to trivial changes (1)

• package/Shaders/ISTemporalAA.hlsl

---

📝 Walkthrough

Walkthrough

Phase 4 neighbor traversal in the ISTemporalAA shader was expanded to include all 9 perimeter samples (BR at index 8) while skipping the center sample; luminance-bounded AABB clamping now uses history-based thresholds; commentary and Phase 6 alpha/luma descriptions were clarified. No public signatures changed.

Changes

Cohort / File(s)

Summary

ISTemporalAA Shader Refinements package/Shaders/ISTemporalAA.hlsl

Increased neighbor traversal loop bound to include BR (index 8) and skip center (index 4); changed min-bracket luma check to use historyLuma (< historyLuma) instead of center upper bound; updated sentinel-collapse and minSentinel trigger comments; clarified reject/mask selection commentary and maskGate semantics; noted BR exclusion from Phase 6 alpha bypass loop and anchored lumaFeedback to lumaC in comments. No API/signature changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• jiayev
• Dlizzio
• doodlum

Poem

🐇 In pixels' hush I hop and peep,
Nine neighbors woke from quiet sleep,
History guides the clamp and song,
Center skipped, the bounds moved strong,
Smooth edges now — a rabbit's leap. 🥕✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(TAA): flicker' directly addresses the main objective of fixing temporal anti-aliasing flickering issues, which aligns with the substantial modifications to the luminance-bounded AABB history clamping logic in the shader.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download

[soda3000]

Changes appear to have resolved the issue according to my testing.