Skip to content

build: fix windows auto deploy script #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 3 commits into from
May 10, 2026
Merged

build: fix windows auto deploy script #2306

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4975f6e
build(cmake): invoke robocopy wrapper via cmd /c absolute path
alandtse May 9, 2026
c8ca33e
build(cmake): stop PREPARE_AIO from racing with copy_shaders on Shaders/
alandtse May 9, 2026
83f47ff
build(cmake): depend AIO archive on copy_shaders.stamp
alandtse May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,13 +352,19 @@ string(TIMESTAMP UTC_NOW "%Y-%m-%dT%H-%MZ" UTC)
# Set AIO directory path used by multiple targets below
set(AIO_DIR "${CMAKE_CURRENT_BINARY_DIR}/aio")

# Robocopy wrapper for Windows incremental file copy (used by deployment targets)
# Robocopy wrapper for Windows incremental file copy (used by deployment targets).
# We invoke through `cmd /c "<absolute-path>"` rather than the bare wrapper path because
# modern Windows refuses to execute scripts from the current directory without an explicit
# `.\` prefix, and CMake strips the absolute path on COMMAND args that live inside
# CMAKE_BINARY_DIR (the custom-build CWD). Treating the wrapper as an argument to cmd
# keeps the absolute path intact in the generated MSBuild command.
if(WIN32)
set(ROBOCOPY_WRAPPER "${CMAKE_BINARY_DIR}/robocopy_wrapper.cmd")
set(ROBOCOPY_WRAPPER_PATH "${CMAKE_BINARY_DIR}/robocopy_wrapper.cmd")
file(
WRITE ${ROBOCOPY_WRAPPER}
WRITE ${ROBOCOPY_WRAPPER_PATH}
"@echo off\r\nrem Robocopy wrapper: forwards all args to robocopy and normalizes exit codes\r\nrobocopy %*\r\nset rc=%ERRORLEVEL%\r\nif %rc% GEQ 8 exit /b %rc%\r\nexit /b 0\r\n"
)
set(ROBOCOPY_WRAPPER cmd /c "${ROBOCOPY_WRAPPER_PATH}")
endif()

# #######################################################################################################################
Expand Down Expand Up @@ -418,14 +424,20 @@ if(AUTO_PLUGIN_DEPLOYMENT OR AIO_ZIP_TO_DIST)

# Prepare AIO only when sources change. Gather package + feature files as
# inputs so the prepare step runs only when something actually changed.
# Shader files are intentionally excluded - copy_shaders.stamp owns those,
# and including them here causes a race where two parallel custom-build
# rules call cmake -E copy_if_different on the same destination file
# (Permission denied on Windows when one process has it open for write).
file(
GLOB_RECURSE _AIO_PACKAGE_FILES
LIST_DIRECTORIES FALSE
"${CMAKE_SOURCE_DIR}/package/*"
)
list(FILTER _AIO_PACKAGE_FILES EXCLUDE REGEX "/Tests/")
list(FILTER _AIO_PACKAGE_FILES EXCLUDE REGEX "/Shaders/")
foreach(_fpath IN LISTS FEATURE_PATHS)
file(GLOB_RECURSE _tmp LIST_DIRECTORIES FALSE "${_fpath}/*")
list(FILTER _tmp EXCLUDE REGEX "/Shaders/")
Comment thread
coderabbitai[bot] marked this conversation as resolved.
list(APPEND _AIO_PACKAGE_FILES ${_tmp})
endforeach()

Expand Down Expand Up @@ -457,23 +469,29 @@ if(AUTO_PLUGIN_DEPLOYMENT OR AIO_ZIP_TO_DIST)
"${CMAKE_SOURCE_DIR}/cmake/CleanupStaleEntries.cmake"
)

# Copy package files (exclude test files from production packages)
# Copy package files (exclude test files from production packages, and
# exclude shaders since copy_shaders.stamp owns those - see input-tracking
# comment above for the race-condition rationale).
file(
GLOB_RECURSE _AIO_PACKAGE_SOURCE_FILES
LIST_DIRECTORIES FALSE
"${CMAKE_SOURCE_DIR}/package/*"
)
list(FILTER _AIO_PACKAGE_SOURCE_FILES EXCLUDE REGEX "/Tests/")
list(FILTER _AIO_PACKAGE_SOURCE_FILES EXCLUDE REGEX "/Shaders/")
append_copy_if_different(_prepare_aio_cmds _AIO_PACKAGE_SOURCE_FILES "${CMAKE_SOURCE_DIR}/package" "${AIO_DIR}")

# Copy feature folders (only files, preserve existing files in AIO)
# Copy feature folders (only files, preserve existing files in AIO).
# Shader files are excluded - copy_shaders.stamp owns the Shaders/ subdir
# so the two custom-build rules don't race on the same destinations.
foreach(_fpath IN LISTS FEATURE_PATHS)
if(EXISTS "${_fpath}")
file(
GLOB_RECURSE _feature_files
LIST_DIRECTORIES FALSE
"${_fpath}/*"
)
list(FILTER _feature_files EXCLUDE REGEX "/Shaders/")
append_copy_if_different(_prepare_aio_cmds _feature_files "${_fpath}" "${AIO_DIR}")
endif()
endforeach()
Expand Down Expand Up @@ -906,7 +924,7 @@ if(AIO_ZIP_TO_DIST)
COMMAND ${CMAKE_COMMAND} -E tar cf ${AIO_ARCHIVE} --format=7zip -- .
COMMAND ${CMAKE_COMMAND} -E touch ${AIO_ZIP_STAMP}
WORKING_DIRECTORY ${AIO_DIR}
DEPENDS PREPARE_AIO
DEPENDS PREPARE_AIO ${CMAKE_CURRENT_BINARY_DIR}/copy_shaders.stamp
COMMENT "Creating AIO archive ${AIO_ARCHIVE}"
)

Expand Down
Loading