fix(fidelityfx): fix fsr feature detection

[doodlum]

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability in enabling or disabling frame generation features based on module loading status.
  • Enhanced error handling with clearer logging when frame generation context creation fails.

[github-actions]

Using provided base ref: 2c9e3c4
Using base ref: 2c9e3c4
Base commit date: 2025-07-16T17:39:38+01:00 (Wednesday, July 16, 2025 05:39 PM)
No actionable suggestions for changed features.

[coderabbitai]

Walkthrough

The changes centralize the logic for setting the featureFSR3FG flag within the LoadFFX function, ensuring it is explicitly set based on the success or failure of module and function loading. The flag is no longer updated in SetupFrameGeneration, which now only logs errors if context creation fails.

Changes

File(s)	Change Summary
src/FidelityFX.cpp	Centralized featureFSR3FG flag assignment to LoadFFX; removed its update from frame generation setup.

Poem

In the warren of code, a flag found its place,
No longer it wanders from function to space.
Now set at the start, with clarity true,
The rabbits rejoice—less hopping to do!
With logs for the errors and features aligned,
The code hops ahead, efficiently designed.
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c9e3c4 and c6b4cac.

📒 Files selected for processing (1)

• src/FidelityFX.cpp (2 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: alandtse
PR: doodlum/skyrim-community-shaders#0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

Learnt from: alandtse
PR: doodlum/skyrim-community-shaders#1157
File: src/Feature.cpp:42-49
Timestamp: 2025-06-17T09:27:49.594Z
Learning: In src/Feature.cpp, when an obsolete feature's INI file is deleted, the feature should be silently disabled without surfacing any issues to the user. This is the intended behavior because a deleted INI file for an obsolete feature indicates that the user has properly cleaned up the obsolete feature.

src/FidelityFX.cpp (1)

Learnt from: alandtse
PR: doodlum/skyrim-community-shaders#1157
File: src/Feature.cpp:42-49
Timestamp: 2025-06-17T09:27:49.594Z
Learning: In src/Feature.cpp, when an obsolete feature's INI file is deleted, the feature should be silently disabled without surfacing any issues to the user. This is the intended behavior because a deleted INI file for an obsolete feature indicates that the user has properly cleaned up the obsolete feature.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build plugin and addons

🔇 Additional comments (2)

src/FidelityFX.cpp (2)

42-47: LGTM! Improved feature detection logic.

This change correctly centralizes the FSR3 frame generation feature detection to the module loading phase. The explicit setting of featureFSR3FG based on module loading success/failure ensures consistent and reliable feature detection, eliminating potential race conditions or inconsistent state that could occur when the flag was set later in the pipeline.

---

63-64: LGTM! Proper separation of concerns.

Removing the featureFSR3FG flag update from this function is correct. Context creation failure is a runtime initialization issue, not a feature availability concern. This prevents the flag from being incorrectly overwritten after it was properly set during module loading in LoadFFX.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

✅ A pre-release build is available for this PR:
Download