fix(ci): --no-worktree on release-smoke archon-assist invocations#1357
fix(ci): --no-worktree on release-smoke archon-assist invocations#1357
Conversation
The two "Smoke-test Claude binary-path resolver" steps in .github/workflows/release.yml run `archon workflow run archon-assist "hello"` against a fresh `git init` temp repo with no origin. As of #1310's worktree-policy changes, default isolation auto-syncs the worktree with origin before creating it, which fails with "neither origin/HEAD nor origin/main exist" — hit before Claude's resolver is even reached, so the test assertions ("Claude Code not found", "CLAUDE_BIN_PATH") never match and the linux-x64 build aborts the whole release matrix. The tests exercise the Claude resolver path, not worktree setup, so --no-worktree is the correct fix: it short-circuits validateAndResolveIsolation and skips the origin sync entirely. Matches the documented usage in CLAUDE.md (`archon workflow run quick-fix --no-worktree "Fix typo"`). Surfaced while cutting v0.3.8 — the release CI failed deterministically on both builds. Binaries themselves are fine (the v0.3.7 Pi-lazy-load fix works; local pre-flight passed on --help). v0.3.8's GitHub Release has been deleted so `releases/latest` falls back to v0.3.6; next release will be v0.3.9 with this fix.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub Actions release workflow has been updated to add the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
v0.3.8's release CI failed deterministically on this step:
The test creates a fresh
git inittempdir with nooriginremote and runsarchon workflow run archon-assist "hello". As of #1310's worktree-policy changes, default isolation auto-syncs the worktree with origin before creation; with no origin, that sync fails — before the Claude resolver is even reached — so the assertion never matches and the whole linux-x64 build aborts (fail-fast kills the other matrix entries).Change
Add
--no-worktreeto both invocations (negative + positive cases). The tests exercise the Claude resolver / subprocess-spawn path, not worktree setup, so skipping isolation is the right answer. This short-circuitsvalidateAndResolveIsolationand never touches origin. Matches the documented usage pattern inCLAUDE.md:Not this PR
bun build --compile --minifyproduces a working binary; the repo's new Step 1.5 pre-flight smoke passes with--help. The only thing broken was the CI assertion, not what it asserts against.releases/latestfalls back to v0.3.6); next release will be v0.3.9 with this fix applied.Test plan
bun run validate(no source changes, should be trivial)Summary by CodeRabbit