Conversation
) The two "Smoke-test Claude binary-path resolver" steps in .github/workflows/release.yml run `archon workflow run archon-assist "hello"` against a fresh `git init` temp repo with no origin. As of #1310's worktree-policy changes, default isolation auto-syncs the worktree with origin before creating it, which fails with "neither origin/HEAD nor origin/main exist" — hit before Claude's resolver is even reached, so the test assertions ("Claude Code not found", "CLAUDE_BIN_PATH") never match and the linux-x64 build aborts the whole release matrix. The tests exercise the Claude resolver path, not worktree setup, so --no-worktree is the correct fix: it short-circuits validateAndResolveIsolation and skips the origin sync entirely. Matches the documented usage in CLAUDE.md (`archon workflow run quick-fix --no-worktree "Fix typo"`). Surfaced while cutting v0.3.8 — the release CI failed deterministically on both builds. Binaries themselves are fine (the v0.3.7 Pi-lazy-load fix works; local pre-flight passed on --help). v0.3.8's GitHub Release has been deleted so `releases/latest` falls back to v0.3.6; next release will be v0.3.9 with this fix.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.3.9
First release with working compiled binaries since v0.3.6. Both v0.3.7 and v0.3.8 were tagged but neither shipped release assets — v0.3.7 was blocked by two genuine binary-runtime bugs (Pi SDK's module-init crash + Bun
--bytecodeproducing broken output), and v0.3.8 was blocked by an unrelated CI smoke-test regression whererelease.yml's Claude resolver test required anoriginremote that the freshgit inittest repo didn't have. Both superseded tags remain for history; their GitHub Releases were deleted at the time of tagging soreleases/latestfell back to v0.3.6 throughout, keepinginstall.shand Homebrew safe. v0.3.9 is what users actually install.Fixed
git inittest repo. The Claude resolver smoke inrelease.ymlranarchon workflow run archon-assistagainst a tempdir with nooriginremote; as of feat(isolation,workflows): worktree location + per-workflow isolation policy #1310's worktree auto-sync logic this fails with "neither origin/HEAD nor origin/main exist" before the resolver is reached, so the CI assertion ("Claude Code not found"in output) never matched and the linux-x64 build aborted — taking the entire release matrix down via fail-fast. Adding--no-worktreeto both the negative and positive resolver tests skips isolation, which is what the tests actually want: they exercise the Claude resolver path, not worktree setup. (fix(ci): --no-worktree on release-smoke archon-assist invocations #1357)Merging this PR releases 0.3.9 to main.