-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demos for legacy, mesh and SDK use cases #5
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just build
is failing for me at the moment
kind.local/client-97313deb5607fb51139af2cb3defb0fc:133a86cf38c89c216b3898fdbdbfe7bc48aefa9a2905bd994e5d21f1d354f47a
ko build -L github.com/cofide/cofide-demos/workloads/cofide/server
Error: failed to publish images: importpath "ko://github.com/cofide/cofide-demos/workloads/cofide/server" is not supported: importpath is not `package main`
error: Recipe `build-cofide-ping-pong` failed on line 75 with exit code 1
|
||
## Quickstart | ||
|
||
### Deploy a single trust zone Cofide instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we define a Cofide "instance"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Cofide 'stack' - ie in this local install, SPIRE. I thought instance worked well, especially as it'd also be applicable for when we provides it via SaaS.
# Cofide Demos | ||
|
||
This repository has an example `ping-pong` application used to demonstrate Cofide's open source tools, including `cofidectl` and the Cofide Go SDK. The examples include ping-pong in a single Cofide trust-zone, as well as an example of ping-pong federated across trust-zones with multiple clusters. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's probably a bunch more context required here on SPIFFE, mTLS, cofidectl, etc. We can follow up with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I'll add some more context. I think we'll likely need extra docs that describe in more detail too.
Justfile
Outdated
# Build the legacy ping-pong applications | ||
build-ping-pong: | ||
ko build -L github.com/cofide/cofide-demos/workloads/ping-pong/server | ||
ko build -L github.com/cofide/cofide-demos/workloads/ping-pong/client | ||
|
||
# Build the ping-pong applications enhanced with the Cofide SDK | ||
build-cofide-ping-pong: | ||
ko build -L github.com/cofide/cofide-demos/workloads/cofide/server | ||
ko build -L github.com/cofide/cofide-demos/workloads/cofide/client | ||
|
||
# Build the ping-pong applications to be deployed in an Istio service mesh | ||
build-ping-pong-mesh: | ||
ko build -L github.com/cofide/cofide-demos/workloads/ping-pong-mesh/server | ||
ko build -L github.com/cofide/cofide-demos/workloads/ping-pong-mesh/client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks as if these need to be updated to reflect the filesystem (explains the build problems I was having before)
Also seeing this after an inplace adjustment:
Error: failed to publish images: error building "ko://github.com/cofide/cofide-demos/workloads/ping-pong-cofide/server": build: go build: exit status 1: # github.com/cofide/cofide-demos/workloads/ping-pong-cofide/server
workloads/ping-pong-cofide/server/main.go:73:27: server.GetIdentity undefined (type *cofide_http_server.Server has no field or method GetIdentity)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because it relies on updates in the cofide-go-sdk
with the new GetIdentity
method:
https://github.com/cofide/cofide-sdk-go/pull/12
Don't we have most of this now in the main branch? |
ko
for leaner/secure container buildscofidectl workload discover
(with secret discovery). Depends on feat: Cache CI-builtcloud-provider-kind
Docker image cofidectl#84.follow-up PR: