Adding cofide-sdk demo example #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbates
reviewed
Oct 23, 2024
mattbates
reviewed
Oct 24, 2024
| docker build -f ./workloads/ping-pong/client/Dockerfile.client -t cofide-demo-ping-pong-client . | ||
|
|
||
| build-cofide-sdk: | ||
| CGO_ENABLED=0 go build -o bin/cofide-sdk/server ./workloads/cofide-sdk/server/main.go |
There was a problem hiding this comment.
Would be great if we could use ko for builds of Go applications. It's super convenient to use and builds lean container images. I use it locally but I'd recommend we use it more widely.
markgoddard
reviewed
Oct 25, 2024
Comment on lines
+1
to
+3
| build: | ||
| just build-ping-pong | ||
| just build-cofide-sdk |
There was a problem hiding this comment.
Use Just dependencies?
Suggested change
| build: | |
| just build-ping-pong | |
| just build-cofide-sdk | |
| build: build-ping-pong build-cofide-sdk |
markgoddard
reviewed
Oct 25, 2024
| ctx, cancel := context.WithTimeout(ctx, 30*time.Second) | ||
| defer cancel() | ||
|
|
||
| client := cofide_http.NewClient( |
There was a problem hiding this comment.
Can we use WithSVIDMatch on the client to match the server's SVID?
|
I've addressed Mark's feedback and added some additional capability in #5. The PR builds on this one so I think we can probably safe close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cofide-sdk-goslot in replacement for Go's HTTP server,cofide_httpgo.mod/binand copy binaries to Docker images (required due to local import of../cofide-sdk-go)