Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cache CI-built cloud-provider-kind Docker image #84

Merged
merged 28 commits into from
Jan 16, 2025

Conversation

nialdaly
Copy link
Contributor

@nialdaly nialdaly commented Dec 13, 2024

Summary

  • Currently the cloud-provider-kind-cloud-provider:latest Docker image is built after checking out the cloud-provider-kind repo and running:
sudo bash -c 'NET_MODE=kind docker compose up -d'
  • Once this image is built, it can be cached (using a composite action) for subsequent workflow runs to use.

@nialdaly nialdaly self-assigned this Dec 13, 2024
@nialdaly nialdaly changed the title feat: Pulled Docker image caching feat: Cache CI-built cloud-provider-kind Docker image Dec 13, 2024
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you see this approach? https://docs.docker.com/build/cache/backends/gha/#using-dockerbuild-push-action

Unsure if it's better, and it would require building the image first, using the cache parameters.

@nialdaly
Copy link
Contributor Author

I've used that in previous places, the change would be as you say to pre-build the image first building it using docker-compose!

@nialdaly nialdaly marked this pull request as ready for review January 8, 2025 18:43
@nialdaly nialdaly changed the title feat: Cache CI-built cloud-provider-kind Docker image WIP: Cache CI-built cloud-provider-kind Docker image Jan 8, 2025
@nialdaly nialdaly marked this pull request as draft January 8, 2025 20:17
@nialdaly nialdaly added this to the release-0.9.0 milestone Jan 9, 2025
@nialdaly nialdaly changed the title WIP: Cache CI-built cloud-provider-kind Docker image feat: Cache CI-built cloud-provider-kind Docker image Jan 9, 2025
@nialdaly nialdaly marked this pull request as ready for review January 9, 2025 13:15
@nialdaly nialdaly requested a review from markgoddard January 10, 2025 10:59
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to extract this into an action to reduce duplication, but I won't block on that.

.github/workflows/integration.yml Outdated Show resolved Hide resolved
@nialdaly nialdaly requested a review from markgoddard January 16, 2025 11:26
@nialdaly nialdaly merged commit 6b51407 into main Jan 16, 2025
6 checks passed
@nialdaly nialdaly deleted the feat-cache-pulled-images branch January 16, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants