Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics for report_json and chunks file sizes #587

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Aug 2, 2024

like #583 and #574

arpad's metrics are already flowing. when this and #583 are deployed, i'll create a dashboard or a few showing p50/p75/p95 for:

  • raw upload size + the number of coverage files contained in a single upload
  • size of each individual coverage file inside an upload
  • the above, grouped by format (cobertura, lcov, jacoco...)
  • report_json size and chunks file size

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
tasks/upload_finisher.py 87.50% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   97.53%   97.52%   -0.01%     
==========================================
  Files         421      421              
  Lines       35244    35258      +14     
==========================================
+ Hits        34374    34386      +12     
- Misses        870      872       +2     
Flag Coverage Δ
integration 97.52% <90.00%> (-0.01%) ⬇️
latest-uploader-overall 97.52% <90.00%> (-0.01%) ⬇️
unit 97.52% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.63% <90.00%> (-0.01%) ⬇️
OutsideTasks 97.75% <100.00%> (ø)
Files Coverage Δ
helpers/metrics.py 100.00% <100.00%> (ø)
services/report/prometheus_metrics.py 100.00% <100.00%> (ø)
services/report/report_processor.py 94.52% <100.00%> (-0.08%) ⬇️
tasks/upload_finisher.py 73.61% <87.50%> (+0.83%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.52%. Comparing base (8d8882d) to head (a7885ec).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   97.53%   97.52%   -0.01%     
==========================================
  Files         421      421              
  Lines       35244    35258      +14     
==========================================
+ Hits        34374    34386      +12     
- Misses        870      872       +2     
Flag Coverage Δ
integration 97.52% <90.00%> (-0.01%) ⬇️
latest-uploader-overall 97.52% <90.00%> (-0.01%) ⬇️
unit 97.52% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.63% <90.00%> (-0.01%) ⬇️
OutsideTasks 97.75% <100.00%> (ø)
Files Coverage Δ
helpers/metrics.py 100.00% <100.00%> (ø)
services/report/prometheus_metrics.py 100.00% <100.00%> (ø)
services/report/report_processor.py 94.52% <100.00%> (-0.08%) ⬇️
tasks/upload_finisher.py 73.61% <87.50%> (+0.83%) ⬆️

Copy link

codecov-public-qa bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.52%. Comparing base (8d8882d) to head (a7885ec).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   97.53%   97.52%   -0.01%     
==========================================
  Files         421      421              
  Lines       35244    35258      +14     
==========================================
+ Hits        34374    34386      +12     
- Misses        870      872       +2     
Flag Coverage Δ
integration 97.52% <90.00%> (-0.01%) ⬇️
latest-uploader-overall 97.52% <90.00%> (-0.01%) ⬇️
unit 97.52% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.63% <90.00%> (-0.01%) ⬇️
OutsideTasks 97.75% <100.00%> (ø)
Files Coverage Δ
helpers/metrics.py 100.00% <100.00%> (ø)
services/report/prometheus_metrics.py 100.00% <100.00%> (ø)
services/report/report_processor.py 94.52% <100.00%> (-0.08%) ⬇️
tasks/upload_finisher.py 73.61% <87.50%> (+0.83%) ⬆️

@matt-codecov matt-codecov requested a review from a team August 2, 2024 21:38
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.57%. Comparing base (8d8882d) to head (a7885ec).

✅ All tests successful. No failed tests found.

Files Patch % Lines
tasks/upload_finisher.py 87.50% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   97.57%   97.57%   -0.01%     
==========================================
  Files         456      456              
  Lines       36450    36464      +14     
==========================================
+ Hits        35566    35578      +12     
- Misses        884      886       +2     
Flag Coverage Δ
integration 97.52% <90.00%> (-0.01%) ⬇️
latest-uploader-overall 97.52% <90.00%> (-0.01%) ⬇️
unit 97.52% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.71% <90.00%> (-0.01%) ⬇️
OutsideTasks 97.75% <100.00%> (ø)
Files Coverage Δ
helpers/metrics.py 100.00% <100.00%> (ø)
services/report/prometheus_metrics.py 100.00% <100.00%> (ø)
services/report/report_processor.py 94.52% <100.00%> (-0.08%) ⬇️
tasks/upload_finisher.py 73.73% <87.50%> (+0.82%) ⬆️

This change has been scanned for critical changes. Learn more

@matt-codecov matt-codecov added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit fc8feb7 Aug 5, 2024
23 of 26 checks passed
@matt-codecov matt-codecov deleted the pr587 branch August 5, 2024 17:17
Copy link

sentry-io bot commented Aug 12, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ FileNotInStorageError: File v4/repos/B84EA580EF5930DE7DFA8855BF62A25F/commits/0d544eaacf41e39b50c9e537fe0e759cc58465f4/c... app.tasks.upload.UploadFinisher View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants