add metric for overall report size #583
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #583 +/- ##
==========================================
+ Coverage 97.50% 97.53% +0.03%
==========================================
Files 414 421 +7
Lines 35002 35244 +242
==========================================
+ Hits 34127 34374 +247
+ Misses 875 870 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 455 456 +1
Lines 36440 36450 +10
=======================================
+ Hits 35556 35566 +10
Misses 884 884
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #583 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 420 421 +1
Lines 35234 35244 +10
=======================================
+ Hits 34364 34374 +10
Misses 870 870
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #583 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 420 421 +1
Lines 35234 35244 +10
=======================================
+ Hits 34364 34374 +10
Misses 870 870
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
the tests fail with that does not repro locally... the metrics are both defined as globals. if they are created twice in prometheus's registry, does that mean the |
matt-codecov
force-pushed
the
pr583
branch
2 times, most recently
from
29c10df
to
1c31799
Compare
|
yes the prints are attempting to diagnose the test failure since i can't reproduce it locally. wondering if it's an issue with an image and if i just try again 12h later if it'll work lol |
|
after much guesswork i appeased prometheus by declaring the metrics in a submodule instead of in |
matt-codecov
dismissed
Swatinem’s stale review
Feedback was about print statements that were in there while debugging CI-only failures. They're gone
arpad added one for the individual coverage files inside of an upload in #574. this PR does the same for the overall upload
an upload contains one or more coverage files, but also path fixes and the output of
git ls-files. so it can be much larger than just the sum of its coverage files. also those coverage files can be b64-encoded which affects the size too(the .gitignore changes help me use Sapling with this repo and aren't important)