Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a metric for the raw report size #574

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Add a metric for the raw report size #574

merged 1 commit into from
Jul 29, 2024

Conversation

Swatinem
Copy link
Contributor

It might be nice to have a histogram with the raw size in bytes for various report formats

@Swatinem Swatinem self-assigned this Jul 26, 2024
@codecov-qa
Copy link

codecov-qa bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (a07ddef) to head (0fdf25c).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         414      414           
  Lines       34982    34986    +4     
=======================================
+ Hits        34105    34109    +4     
  Misses        877      877
Flag Coverage Δ
integration 97.49% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.49% <100.00%> (+<0.01%) ⬆️
unit 97.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.70% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/report_processor.py 94.59% <100.00%> (+0.30%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         414      414           
  Lines       34982    34986    +4     
=======================================
+ Hits        34105    34109    +4     
  Misses        877      877
Flag Coverage Δ
integration 97.49% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.49% <100.00%> (+<0.01%) ⬆️
unit 97.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.70% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/report_processor.py 94.59% <100.00%> (+0.30%) ⬆️

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (a07ddef) to head (0fdf25c).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         414      414           
  Lines       34982    34986    +4     
=======================================
+ Hits        34105    34109    +4     
  Misses        877      877
Flag Coverage Δ
integration 97.49% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.49% <100.00%> (+<0.01%) ⬆️
unit 97.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.70% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/report_processor.py 94.59% <100.00%> (+0.30%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (a07ddef) to head (0fdf25c).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         449      449           
  Lines       36188    36192    +4     
=======================================
+ Hits        35299    35303    +4     
  Misses        889      889
Flag Coverage Δ
integration 97.49% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.49% <100.00%> (+<0.01%) ⬆️
unit 97.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.64% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.70% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/report_processor.py 94.59% <100.00%> (+0.30%) ⬆️
Related Entrypoints
run/app.tasks.profiling.normalizer
run/app.tasks.upload.UploadProcessor

matt-codecov
matt-codecov approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@matt-codecov matt-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! would like to see buckets for larger report sizes, but also once this is deployed i imagine we'll immediately query it in grafana and see if there's even an issue. it's easy to change the bucket sizes later

services/report/report_processor.py Show resolved Hide resolved
services/report/report_processor.py
for processor in processors:
if processor.matches_content(parsed_report, first_line, name):
sentry_metrics.incr(
"services.report.report_processor.parser",
tags={"type": type(processor).__name__},
)
RAW_REPORT_SIZE.labels(processor=processor.name).observe(report.size)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the callsite for this function to double-check that report here is indeed a single raw coverage report embedded inside of a larger Codecov upload

worker/services/report/raw_upload_processor.py

Lines 159 to 161 in a07ddef

report = process_report(
report=report_file, report_builder=report_builder_to_use
)

@Swatinem
Add a metric for the raw report size
0fdf25c 
It might be nice to have a histogram with the raw size in bytes for various report formats
@Swatinem Swatinem force-pushed the swatinem/report-size-metric branch from d6da843 to 0fdf25c Compare July 29, 2024 08:34
@Swatinem Swatinem enabled auto-merge July 29, 2024 08:35
@Swatinem Swatinem added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit 2a6cb28 Jul 29, 2024
30 checks passed
@Swatinem Swatinem deleted the swatinem/report-size-metric branch July 29, 2024 08:48
This was referenced Aug 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-codecov matt-codecov matt-codecov approved these changes

Assignees

@Swatinem Swatinem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swatinem @matt-codecov