Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix fallback system in GH (again) #245

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: fix fallback system in GH (again) #245

merged 1 commit into from
Jun 10, 2024

Commits on Jun 7, 2024

  1. fix: fix fallback system in GH (again) 

    I broke the GH fallback system again 😅
Fixes this issue: https://l.codecov.dev/dEsZeK

The problem is that since #225
(technically codecov/worker#470 actually) we include 1 extra piece of information in `GitHubAppInstallationInfo`, the `GitHubAppInstallation.id`.

This is breaking the function that gets tokens because we are destructuring the info dict
into the kwargs for the function (with the extra, unexpected `id` one).

To fix that we just pop it before calling the function.
    @giovanni-guidini
    giovanni-guidini committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    96bab58 View commit details
    Browse the repository at this point in the history