Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Sentry Metrics Integration #2529

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Jan 23, 2024

Description

This PR enables the Sentry metrics integration into the Sentry init call, for some upcoming work in Gazebo.

GH codecov/engineering-team#998

Notable Changes

  • Enable Sentry's metric integration in sentry.ts
  • Update Sentry related packages

@codecov-qa
Copy link

codecov-qa bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be8bc8d) 98.29% compared to head (fef82df) 98.29%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2529   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         799      799           
  Lines       10291    10291           
  Branches     2581     2535   -46     
=======================================
  Hits        10116    10116           
  Misses        173      173           
  Partials        2        2           
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8bc8d...fef82df. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 23, 2024

Codecov Report

Merging #2529 (fef82df) into main (be8bc8d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2529   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         799      799           
  Lines       10291    10291           
  Branches     2535     2567   +32     
=======================================
  Hits        10116    10116           
  Misses        173      173           
  Partials        2        2           
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8bc8d...fef82df. Read the comment docs.

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit fef82df
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65b0060784759d00087aedb6
😎 Deploy Preview https://deploy-preview-2529--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2529   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         799      799           
  Lines       10291    10291           
  Branches     2581     2537   -44     
=======================================
  Hits        10116    10116           
  Misses        173      173           
  Partials        2        2           
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8bc8d...fef82df. Read the comment docs.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be8bc8d) 98.30% compared to head (fef82df) 98.30%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2529   +/-   ##
=====================================
  Coverage   98.30   98.30           
=====================================
  Files        799     799           
  Lines      10291   10291           
  Branches    2537    2581   +44     
=====================================
  Hits       10116   10116           
  Misses       173     173           
  Partials       2       2           
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8bc8d...fef82df. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 5032e1d into main Jan 23, 2024
60 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-998-enable-metrics-in-sentry-config branch January 23, 2024 18:42
RulaKhaled pushed a commit that referenced this pull request Jan 25, 2024
Update Sentry deps, as well as enabling Sentry metrics integration in sentry.ts.

GH codecov/engineering-team#998
RulaKhaled added a commit that referenced this pull request Jan 25, 2024
* feat: Update with global token if exists

* feat: Update circleci with global token if exists

* build: Update deps related to Adobe CSS (#2530)

Update deps related to Adobe CSS tools.

* feat: Enable Sentry Metrics Integration (#2529)

Update Sentry deps, as well as enabling Sentry metrics integration in sentry.ts.

GH codecov/engineering-team#998

* feat: Create Webpack plugin onboarding steps (#2516)

Create onboarding steps for bundle analysis webpack steps.

GH codecov/engineering-team#1043

* feat: Restructure PR Page (#2520)

Restructure the PR page moving coverage related components down one level to make space in the current PR page for expanding product set.

GH codecov/engineering-team#997

* feat: Restructure Commit Detail Page (#2523)

Move all coverage related items in the commit detail page down one level to the commit coverage directory in prep for adding in bundle analysis.

GH codecov/engineering-team#996

* fix: Move fetching of org upload token to a different hook (#2536)

Move fetching of the org upload token into it's own hook so we can call it precisely when we need it, instead of over fetching it.

* update with new global token hook

---------

Co-authored-by: nicholas-codecov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants