feat: Restructure PR Page #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undle analysis stuff
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2520 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 800 800
Lines 10303 10304 +1
Branches 2586 2586
=======================================
+ Hits 10128 10129 +1
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2520 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 800 800
Lines 10303 10304 +1
Branches 2586 2567 -19
=======================================
+ Hits 10128 10129 +1
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2520 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 800 800
Lines 10303 10304 +1
Branches 2581 2581
=======================================
+ Hits 10128 10129 +1
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2520 +/- ##
=====================================
Coverage 98.30 98.30
=====================================
Files 800 800
Lines 10303 10304 +1
Branches 2581 2581
=====================================
+ Hits 10128 10129 +1
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
rohitvinnakota-codecov
approved these changes
Jan 22, 2024
adrian-codecov
approved these changes
Jan 23, 2024
nicholas-codecov
deleted the
gh-eng-997-update-pr-page-restructure-pr-page
branch
RulaKhaled
pushed a commit
that referenced
this pull request
Jan 25, 2024
Restructure the PR page moving coverage related components down one level to make space in the current PR page for expanding product set. GH codecov/engineering-team#997
RulaKhaled
added a commit
that referenced
this pull request
Jan 25, 2024
* feat: Update with global token if exists * feat: Update circleci with global token if exists * build: Update deps related to Adobe CSS (#2530) Update deps related to Adobe CSS tools. * feat: Enable Sentry Metrics Integration (#2529) Update Sentry deps, as well as enabling Sentry metrics integration in sentry.ts. GH codecov/engineering-team#998 * feat: Create Webpack plugin onboarding steps (#2516) Create onboarding steps for bundle analysis webpack steps. GH codecov/engineering-team#1043 * feat: Restructure PR Page (#2520) Restructure the PR page moving coverage related components down one level to make space in the current PR page for expanding product set. GH codecov/engineering-team#997 * feat: Restructure Commit Detail Page (#2523) Move all coverage related items in the commit detail page down one level to the commit coverage directory in prep for adding in bundle analysis. GH codecov/engineering-team#996 * fix: Move fetching of org upload token to a different hook (#2536) Move fetching of the org upload token into it's own hook so we can call it precisely when we need it, instead of over fetching it. * update with new global token hook --------- Co-authored-by: nicholas-codecov <[email protected]>
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restructures the current pull request page quite heavily, and moves lots of the current sub-routes into the
PullCoveragedirectory in preparation for bundle analysis.GH codecov/engineering-team#997
Notable Changes
PullRequestPageContenttoPullCoveragePullRequestPagetoPullCoverage