Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] Update PR Page #997

Closed
7 of 10 tasks
Tracked by #741
nicholas-codecov opened this issue Jan 5, 2024 · 0 comments
Closed
7 of 10 tasks
Tracked by #741

[Client] Update PR Page #997

nicholas-codecov opened this issue Jan 5, 2024 · 0 comments
Assignees

Comments

@nicholas-codecov
Copy link

nicholas-codecov commented Jan 5, 2024

We need to update the PR Page to support displaying the new bundle analysis information.

Designs can be found here.


The dropdowns should automatically open if the following query param is passed via the url:

  • ?dropdown=coverage
    • Auto open coverage dropdown
  • ?dropdown=bundle
    • Auto open bundle analysis dropdown

There are a couple different states that can appear on the commit detail page:

  • There is only coverage data:
    • Display what we currently have
  • There is only bundle analysis data:
    • Display only bundle analysis table (with summary information)
  • There is both coverage and bundle analysis data:
    • Display dropdowns with coverage and bundle analysis information

Things to do


Blocked by

  1. 1 of 3
    nicholas-codecov
  2. nicholas-codecov
@nicholas-codecov nicholas-codecov self-assigned this Jan 5, 2024
nicholas-codecov added a commit to codecov/gazebo that referenced this issue Jan 24, 2024
Restructure the PR page moving coverage related components down one level to make space in the current PR page for expanding product set.

GH codecov/engineering-team#997
RulaKhaled pushed a commit to codecov/gazebo that referenced this issue Jan 25, 2024
Restructure the PR page moving coverage related components down one level to make space in the current PR page for expanding product set.

GH codecov/engineering-team#997
RulaKhaled added a commit to codecov/gazebo that referenced this issue Jan 25, 2024
* feat: Update with global token if exists

* feat: Update circleci with global token if exists

* build: Update deps related to Adobe CSS (#2530)

Update deps related to Adobe CSS tools.

* feat: Enable Sentry Metrics Integration (#2529)

Update Sentry deps, as well as enabling Sentry metrics integration in sentry.ts.

GH codecov/engineering-team#998

* feat: Create Webpack plugin onboarding steps (#2516)

Create onboarding steps for bundle analysis webpack steps.

GH codecov/engineering-team#1043

* feat: Restructure PR Page (#2520)

Restructure the PR page moving coverage related components down one level to make space in the current PR page for expanding product set.

GH codecov/engineering-team#997

* feat: Restructure Commit Detail Page (#2523)

Move all coverage related items in the commit detail page down one level to the commit coverage directory in prep for adding in bundle analysis.

GH codecov/engineering-team#996

* fix: Move fetching of org upload token to a different hook (#2536)

Move fetching of the org upload token into it's own hook so we can call it precisely when we need it, instead of over fetching it.

* update with new global token hook

---------

Co-authored-by: nicholas-codecov <[email protected]>
nicholas-codecov added a commit to codecov/gazebo that referenced this issue Jan 25, 2024
Update the usePullPageData hook to grab product status fields.

GH codecov/engineering-team#997
nicholas-codecov added a commit to codecov/gazebo that referenced this issue Jan 30, 2024
nicholas-codecov added a commit to codecov/gazebo that referenced this issue Feb 5, 2024
Create dropdown for the pull request page for bundle analysis.

GH codecov/engineering-team#997
nicholas-codecov added a commit to codecov/gazebo that referenced this issue Feb 11, 2024
Set the pull request page to render bundle data if the repo has bundle data, and the user has access to the feature flag.

GH codecov/engineering-team#997
nicholas-codecov added a commit to codecov/gazebo that referenced this issue Feb 13, 2024
Update warning icons for bundle analysis stuff, as well as fix casing for pull summary messages, and pull bundle only message.

GH codecov/engineering-team#996
GH codecov/engineering-team#997
GH codecov/engineering-team#1024
nicholas-codecov added a commit to codecov/gazebo that referenced this issue Feb 15, 2024
Handle various errors in the pulls tab for the bundle dropdown.

GH codecov/engineering-team#997
@codecov-hooky codecov-hooky bot closed this as completed Feb 16, 2024
@codecov-hooky codecov-hooky bot closed this as completed Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant