roachtest: simplify and deflake cleanup in clock jump test #156369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes cockroachdb#156339. Epic: none
Member
|
This change is |
stevendanna
approved these changes
Oct 30, 2025
Collaborator
stevendanna
left a comment
stevendanna
left a comment
There was a problem hiding this comment.
Looks like the test run passed.
| // exactly the clock jumps, we simply stop and wipe the node (which also | ||
| // prevents the post-test assertions from complaining about a down node). | ||
| c.Wipe(ctx, c.All()) | ||
| offsetInjector.recover(ctx, c.Spec().NodeCount) |
Collaborator
There was a problem hiding this comment.
Is this here in case the cluster gets re-used by another roachtest?
Member
Author
There was a problem hiding this comment.
Yeah, I think this is just for good hygiene. I'm actually not sure, maybe the failover tests reuse the clusters between each other, too.
tbg
changed the title
Member
Author
|
TFTR! bors r+ |
tbg
added
the
backport-all
Contributor
This was referenced Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156339.
Passing test run: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/20660221?hideTestsFromDependencies=false&hideProblemsFromDependencies=false
Epic: none