Skip to content

Conversation

@tbg
Copy link
Member

@tbg tbg commented Oct 30, 2025

@tbg tbg force-pushed the blathers/backport-release-24.3-156369 branch from c1e6022 to 49bf137 Compare October 30, 2025 10:29
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 30, 2025
@blathers-crl blathers-crl bot requested a review from stevendanna October 30, 2025 10:29
@blathers-crl
Copy link

blathers-crl bot commented Oct 30, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-kv KV Team labels Oct 30, 2025
@blathers-crl
Copy link

blathers-crl bot commented Oct 30, 2025

✅ PR #156526 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The PR modifies a file within a directory explicitly designated as non-production code as per the CockroachDB Backport Policy, specifically pkg/cmd/roachtest/. The changes are to a file used solely for testing (tests/clock_jump_crash.go), thus adhering to the exemption for non-production and test-only changes. Additionally, the PR includes a 'Release justification: Test-only change.' which further supports its exemption from the standard backport policy requirements.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Oct 30, 2025
@tbg tbg merged commit b4c668b into cockroachdb:release-24.3 Oct 30, 2025
16 checks passed
@tbg tbg deleted the blathers/backport-release-24.3-156369 branch October 30, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-kv KV Team v24.3.23

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants