catalog/lease: fix flake for TestTableCreationPushesTxnsInRecentPast #115046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
fqazi
force-pushed
the
TestTableCreationPushesTxnsInRecentPastFlake
branch
from
28a1765 to
3de9757
Compare
rafiss
reviewed
Nov 24, 2023
Collaborator
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @fqazi)
-- commits line 9 at r1:
just for my own education: could you say more about why this causes the desired behavior?
Previously, TestTableCreationPushesTxnsInRecentPast could flake because we attempted to increase the uncertainty interval error by adding a delay on KV RPC calls to make the uncertainty interval larger. This would work based on the observed timestamp having a variance between nodes. This wasn't effective, and we could still have intermittent failures, because the variance was not large enough. To address this, this patch will increase the maximum offset on the HLC clock itself, which is used as the base value for computing the uncertainty interval (see computeIntervalForTxn). With this change, we expect a more deterministic reproduction of the txn getting pushed because of the uncertainty interval. Fixes: cockroachdb#114366 Release note: None
fqazi
force-pushed
the
TestTableCreationPushesTxnsInRecentPastFlake
branch
from
3de9757 to
1fb0eac
Compare
fqazi
commented
Nov 24, 2023
Collaborator
Author
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
Reviewable status:
Previously, rafiss (Rafi Shamim) wrote…
just for my own education: could you say more about why this causes the desired behavior?
I updated the commit message for why it should work
rafiss
approved these changes
Nov 27, 2023
Collaborator
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
nice thanks for the explanation!
Reviewable status:
Collaborator
Author
|
@rafiss TFTR! bors r+ |
Contributor
|
Build succeeded: |
Collaborator
|
blathers backport 23.2 |
Collaborator
|
blathers backport 23.2.0-rc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, TestTableCreationPushesTxnsInRecentPast could flake because we attempted to increase odds of hitting the uncertainty interval error by adding a delay on KV RPC calls. This wasn't effective and could still intermittent failures, and instead we are going to directly modify the uncertainty interval by setting a large MaxOffset on the clock. This will cause the desired behaviour in a more deterministic way.
Fixes: #114366
Release note: None