Skip to content

release-23.2: catalog/lease: fix flake for TestTableCreationPushesTxnsInRecentPast #116551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2023
Merged

release-23.2: catalog/lease: fix flake for TestTableCreationPushesTxnsInRecentPast #116551

merged 1 commit into from
Dec 18, 2023

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Dec 15, 2023 •
edited by rafiss
Loading

Backport 1/1 commits from #115046 on behalf of @fqazi.

/cc @cockroachdb/release

Previously, TestTableCreationPushesTxnsInRecentPast could flake because we attempted to increase odds of hitting the uncertainty interval error by adding a delay on KV RPC calls. This wasn't effective and could still intermittent failures, and instead we are going to directly modify the uncertainty interval by setting a large MaxOffset on the clock. This will cause the desired behaviour in a more deterministic way.

Fixes: #114366

Release note: None

Release justification: test only change

@fqazi
catalog/lease: fix flake for TestTableCreationPushesTxnsInRecentPast
0d10bdc 
Previously, TestTableCreationPushesTxnsInRecentPast could flake because
we attempted to increase the uncertainty interval error by adding a
delay on KV RPC calls to make the uncertainty interval larger. This
would work based on the observed timestamp having a variance between
nodes. This wasn't effective, and we could still have intermittent
failures, because the variance was not large enough. To address this,
this patch will increase the maximum offset on the HLC clock itself,
which is used as the base value for computing the uncertainty interval
(see computeIntervalForTxn). With this change, we expect a more
deterministic reproduction of the txn getting pushed because of the
uncertainty interval.

Fixes: #114366

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 15, 2023 16:32
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115046 branch from 957d350 to 0d10bdc Compare December 15, 2023 16:32
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 15, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Dec 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from fqazi and rafiss December 15, 2023 16:32
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 15, 2023
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 15, 2023

This change is Reviewable

@rafiss rafiss merged commit 275567b into release-23.2 Dec 18, 2023
@rafiss rafiss deleted the blathers/backport-release-23.2-115046 branch December 18, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafiss rafiss rafiss approved these changes

@fqazi fqazi Awaiting requested review from fqazi

Assignees

@fqazi fqazi

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cockroach-teamcity @rafiss @fqazi